Bug 507410

H Rakesh,

 I'm not an official package reviewer.

 There are some .pyc/o files that need adding to the files list.

 Currently:

 error: Installed (but unpackaged) file(s) found:
   /usr/lib/yum-plugins/download-order.pyc
   /usr/lib/yum-plugins/download-order.pyo

 see:
 
 https://fedoraproject.org/wiki/Packaging:Python#Byte_Compiled_Files

 This is on F11.

Steve

In you spec, include all the python generated files with

/usr/lib/yum-plugins/download-order.py*


And you can join 
%doc README 
%doc COPYING

in 
%doc README COPYING

SPEC: http://rakesh.fedorapeople.org/spec/yum-download-order.spec
SRPM: http://rakesh.fedorapeople.org/srpm/yum-download-order-0.1-2.fc11.src.rpm

Updated .. may you check this out whether it generates pyc and pyo files ? Removed Makefile and have used setup.py similar to yum-presto plugin spec file

Thanks,

FYI, In Fedora 11, all plugins have the name yum-plugin-foo instead of yum-foo.

except yum-presto which till now was only one outside provided yum-utils until this one came.

@Rahul
Seems it is between to rename to yum-plugin-foo .. will update in some time.

@Sergio 
I will rename it ... waiting for review between.

Rakesh, the tarball upstream doesn't match the source in rpm. Please upload the new tarball so that I can write the review.

Other things:
  
 * why do you need python-setuptools-devel?, python-setuptools is enough to build and install most python applications.
 * the current recommended macro for python_sitelib is:

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}

 just change define by global http://fedoraproject.org/wiki/Packaging:Python

 * download-order.py has a shebang in the first line. As this file isn't a script
   intended to be run by users, I think its better to remove it (when we also remove a rpmlint error)

Rakesh, the tarball upstream doesn't match the source in rpm. Please upload the
new tarball so that I can write the review.

Sergio, I am on holidays and will do it in some days depending on time I get for this week (no access to my test box at working place). If I miss this week I will surely do it first week of Augest after going back to my place.

Thanks for waiting,

SPEC: http://rakesh.fedorapeople.org/spec/yum-download-order.spec
SRPM: http://rakesh.fedorapeople.org/srpm/yum-download-order-0.1-2.fc11.src.rpm

I have updated the tarball.

(In reply to comment #10)
> Thanks for waiting,
> 
> SPEC: http://rakesh.fedorapeople.org/spec/yum-download-order.spec
> SRPM: http://rakesh.fedorapeople.org/srpm/yum-download-order-0.1-2.fc11.src.rpm
> 

Corrected Urls:

SPEC: http://rakesh.fedorapeople.org/spec/yum-download-order.spec
SRPM: http://rakesh.fedorapeople.org/srpm/yum-download-order-0.1-3.fc11.src.rpm

@ Sergio, ping ??

For me it seams that the stuff from comment #7 wasn't incorporated in the spec file.  Am I wrong?

Included them,

SPEC: http://rakesh.fedorapeople.org/spec/yum-download-order.spec
SRPM: http://rakesh.fedorapeople.org/srpm/yum-download-order-0.1-4.fc11.src.rpm

rpmlint OK
name: a better name would be yum-plugin-download-order
license: OK
license included: OK
spec legible: OK
sources match upstream: OK
compiles: FAIL, you have to add python-devel to BuildRequires to compile the package
it owns all directories that it creates: OK
permissions: OK
clean section: OK
macros consistent: OK

So, you have to add python-devel to BuildRequires. A better name for the package
is yum-plugin-download-order, according to the majority of the yum plugins

http://rakesh.fedorapeople.org/spec/yum-plugin-download-order.spec
http://rakesh.fedorapeople.org/srpm/yum-plugin-download-order-0.1-5.fc12.src.rpm

Updated with both changes.

Thanks,

APPROVED, thanks

New Package CVS Request
=======================

Package Name: yum-plugin-download-order
Short Description: Yum plugin to order downloading of packages
Owners: rakesh
Branches: F-10 F-11
InitialCC:

cvs done.

yum-plugin-download-order-0.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/yum-plugin-download-order-0.2-1.fc11

yum-plugin-download-order-0.1-5.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/yum-plugin-download-order-0.1-5.fc10

yum-plugin-download-order-0.1-5.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

yum-plugin-download-order-0.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.