Bug 507430

Summary:	S/Lang stack / memory leaks
Product:	[Retired] Red Hat Cluster Suite	Reporter:	Lon Hohberger <lhh>
Component:	rgmanager	Assignee:	Lon Hohberger <lhh>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4	CC:	cfeist, cluster-maint, djansa, edamato, fnadge, tdunnon
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rgmanager-1.9.88-1.el4	Doc Type:	Bug Fix
Doc Text:	Previously, the S/Lang code could lead to unwanted S/Lang stack leaks during event processing. With this update, the S/Lang stack has no more memory leaks.	Story Points:	---
Clone Of:
Clones:	507431 (view as bug list)		Environment:
Last Closed:	2011-02-16 15:09:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lon Hohberger 2009-06-22 18:22:43 UTC

Description of problem:

During event processing, an error in the S/Lang code can produce unwanted S/Lang stack leaks.  This can be fixed a number of ways, for example, purging the stack at the end of each run.  However, the correct fix is to not leak the variables in the first place.

After several hundred events are handled, the S/Lang stack can fill up, requiring a retry of the service operation.  On failover, this could result in a service not running if central_processing is enabled.

Normally, however, it's during a user operation, requiring a retry of that operation.

Comment 1 Lon Hohberger 2009-06-22 18:26:34 UTC

Additionally, a duplicated buffer when pushing service properties on to the stack was getting leaked.

Patches:

http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=6b4e6f18cfa7a03b1ee1008a019aad077e3954fc
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=2707f7fefd49f07a89f52b093be4bef86d2ccf77
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=692e03a144b871186c76945ab915f476fbf912ab
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=4ca1c6629655cd0b468fbc0e63b1f80729001f28

Comment 5 Lon Hohberger 2010-10-22 19:56:36 UTC

http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=371a1a0eaff5c89cafe49f51d7494d4a10676a1a

Comment 8 Florian Nadge 2011-01-03 14:12:08 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, the S/Lang code could lead to unwanted S/Lang stack leaks during event processing. With this update, the S/Lang stack has no more memory leaks.

Comment 9 errata-xmlrpc 2011-02-16 15:09:28 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0264.html