Bug 507431

Summary: S/Lang stack / memory leaks
Product: Red Hat Enterprise Linux 5 Reporter: Lon Hohberger <lhh>
Component: rgmanagerAssignee: Lon Hohberger <lhh>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: low    
Version: 5.4CC: cluster-maint, edamato
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rgmanager-2.0.52-1.9 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 507430 Environment:
Last Closed: 2010-03-30 08:49:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lon Hohberger 2009-06-22 18:28:12 UTC 
Description of problem:

During event processing, an error in the S/Lang code can produce unwanted S/Lang stack leaks.  This can be fixed a number of ways, for example, purging the stack at the end of each run.  However, the correct fix is to not leak the variables in the first place.

After several hundred events are handled, the S/Lang stack can fill up, requiring a retry of the service operation.  On failover, this could result in a service not running if central_processing is enabled.

Normally, however, it's during a user operation, requiring a retry of that operation.

Additionally, a duplicated buffer when pushing service properties on to the stack was getting leaked.
Comment 1 Lon Hohberger 2009-06-22 18:28:59 UTC 
Patches:

http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=c2600ba9290b8e3d35f4a8d0fb0d2c01c71a6021
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=09b0c9418c4d8165e897e6a3d2e8fac17d7de046
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=9ca813337c7173e3889dc31986f3fc906a7c66c5
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=50e03f60bb942d309d8198ac9d1827216ddff088
Comment 2 Lon Hohberger 2009-06-23 15:19:20 UTC 
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=85bc0c65b53325c5a0e0489d0b04bda15e83d3f2
Comment 3 Lon Hohberger 2009-06-26 18:25:02 UTC 
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=4730b0a0f8ec1021115fc626a59b97a5920244a8
Comment 6 Lon Hohberger 2009-09-28 15:44:01 UTC 
Those commits are obsolete; I will have new ones momentarily.
Comment 7 Lon Hohberger 2009-09-28 16:04:23 UTC 
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=e9277676d10b511efee18342b60088bfd85e0ba9
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=51e9b45f109b1678413228f3654de55cb935ed90
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=0500b5311a809ea119599488374ef094b633f1d5
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=7215e7160a3e32c84d4fa27c1f959b04239243d7
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=fd4876528b72d9cf06fa06b2ea992ee314ca0d72
Comment 8 Lon Hohberger 2009-10-06 20:04:46 UTC 
http://git.fedorahosted.org/git/?p=cluster.git;a=commit;h=fd4876528b72d9cf06fa06b2ea992ee314ca0d72
Comment 12 errata-xmlrpc 2010-03-30 08:49:26 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0280.html