Red Hat Bugzilla – Full Text Bug Listing
|Summary:||Review Request: rubygem-rubyzip - Ruby module for reading and writing zip files|
|Product:||[Fedora] Fedora||Reporter:||Michael Stahnke <mastahnke>|
|Component:||Package Review||Assignee:||Mamoru TASAKA <mtasaka>|
|Status:||CLOSED NOTABUG||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2009-08-24 11:45:03 EDT||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Bug Depends On:|
Description Michael Stahnke 2009-06-23 10:48:25 EDT
Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-rubyzip.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-rubyzip-0.9.1-1.fc10.src.rpm Description: rubyzip is a ruby module for reading and writing zip files
Comment 1 Mamoru TASAKA 2009-06-23 12:10:23 EDT
I will take this one. Instead I will appreciate it if you would review either of my review requests (bug 506168 or bug 507649, both are rubygem related)
Comment 2 Mamoru TASAKA 2009-06-23 13:58:44 EDT
Some notes for 0.9.1-1: * %define -> %global - Now Fedora suggests to use %global instead of %define. ref: https://fedoraproject.org/wiki/Packaging/Ruby#Pure_Ruby_packages https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define * License - When it is written as "is distributed under the same license as ruby", the license tag should be "GPLv2 or Ruby". * ruby(abi) Requires - All ruby related packages must have "Requires: ruby(abi) = 1.8". And for consistency I always recommend to also add "BuildRequires: ruby(abi) = 1.8". https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * %check - As this gem file contains test/ directory, please add %check stage and execute some tests. ( And for this case, I guess expanding gem file under %_builddir at %prep is preferred, ref: https://fedoraproject.org/wiki/PackagingDrafts/Gem_expand_stage_change also see: http://mtasaka.fedorapeople.org/Review_request/rubygem-mocha/rubygem-mocha.spec ) * %files - As you already defined %geminstdir, please use it also on %files - %defattr must be set before writing %doc entry. - The directory %geminstdir itself is not owned by this package.
Comment 3 Mamoru TASAKA 2009-07-01 10:22:32 EDT
Comment 4 Michael Stahnke 2009-07-01 23:28:58 EDT
hi. I started re-working the spec file to include your recommendations. %check will be the hardest part. I will finish tomorrow (US).
Comment 5 Mamoru TASAKA 2009-07-15 14:15:37 EDT
Comment 6 Mamoru TASAKA 2009-07-23 12:01:51 EDT
Comment 7 Mamoru TASAKA 2009-08-04 13:09:59 EDT
Comment 8 Mamoru TASAKA 2009-08-14 11:38:16 EDT
I will close this bug as NOTABUG if no response from the reporter is received within ONE WEEK.
Comment 9 Mamoru TASAKA 2009-08-24 11:45:03 EDT
Closing. If someone want to import this package into Fedora, please file a new review request and mark this bug as a duplicate of the new one. Thank you!