Bug 507954

Description of problem:

yum-updatesd, when configured to generate syslog entries, does not generate the entries with the configured (or default) syslog identifier.  In all cases, the syslog identifier is null.

For example:

Jun 24 12:57:06 huggy : 8 updates available

It should rather be:

Jun 24 12:57:06 huggy yum-updatesd: 8 updates available

Version-Release number of selected component (if applicable):

yum-updatesd-0.9-1.fc9.noarch

Here is the command-line I used to test the settings:

# /usr/libexec/yum-updatesd-helper --syslog --syslog-level=WARN --syslog-facility=DAEMON --syslog-ident=yum-updatesd --debug --check

And here is my yum-updatesd.conf file:

[main]
# how often to check for new updates (in seconds)
run_interval = 10800
# how often to allow checking on request (in seconds)
updaterefresh = 600

# how to send notifications (valid: dbus, email, syslog)
emit_via = syslog
# should we listen via dbus to give out update information/check for
# new updates 
dbus_listener = no

# automatically install updates
do_update = no
# automatically download updates
do_download = no
# automatically download deps of updates
do_download_deps = no

How reproducible:

always

Steps to Reproduce:
1. configure /etc/yum/yum-updatesd.conf to generate syslog notifications
2. run yum-updatesd on a system that requires updates
3.
  
Actual results:


Expected results:


Additional info:

From what I can tell, yum-updatesd is stumbling over the the YUM library, which re-initializes the syslog facility (see YumBase.doConfigSetup).  Unless there is a syslog configuration in yum.conf, it gets reset to use a null syslog ident.

There are a variety of fixes, but the one I came up with (please forgive me) is to re-initialize syslog immediately after the YUM library is initialized.  Feel free to suggest a cleaner solution.  See my patch:

diff -u /usr/libexec/yum-updatesd-helper /tmp/yum-updatesd-helper 
--- /usr/libexec/yum-updatesd-helper	2007-12-17 20:19:44.000000000 -0800
+++ /tmp/yum-updatesd-helper	2009-06-24 13:01:17.421686194 -0700
@@ -347,17 +347,30 @@
                                                     self.options.smtpserver,
                                                     self.options.sendmail))
         if self.options.syslog:
-            self.emitters.append(SyslogUpdateEmitter(self.options.logfacility,
-                                                     self.options.logident,
-                                                     self.options.loglevel))
+            self.syslog_emitter = SyslogUpdateEmitter(self.options.logfacility,
+                                                      self.options.logident,
+                                                      self.options.loglevel)
+            self.emitters.append(self.syslog_emitter)
         if self.options.debug:
             self.emitters.append(StderrUpdateEmitter())
         self.updateInfo = []
 
+    def doSetupSyslog(self):
+        """Initialize or re-initialize the syslog facility.
+
+        Note that the YUM library re-initializes syslog.
+        """
+        if self.options.syslog:
+            syslog.openlog(self.options.logident,
+                           0,
+                           self.syslog_emitter._facilityMap(self.options.logfacility))
+        
     def doSetup(self):
         try:
             self.doConfigSetup(fn=self.options.config)
+            self.doSetupSyslog()
         except Exception, e:
+            self.doSetupSyslog()
             syslog.syslog(syslog.LOG_WARNING,
                           "error initializing: %s" % e)