Bug 508139
| Summary: | livecd-creator doesn't create on rawhide | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | |
| Component: | yum | Assignee: | Seth Vidal <skvidal> | |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | low | |||
| Version: | rawhide | CC: | davidz, ffesti, james.antill, jlaska, katzj, pmatilai, tim.lauridsen, wtogami | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 508659 (view as bug list) | Environment: | ||
| Last Closed: | 2009-07-23 21:30:53 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
|
Description
Matthias Clasen
2009-06-25 19:34:00 UTC
The same result with the f11 repos instead of rawhide. Builds are working for me here although bug 505121 is still present. Is this an i386 or x86_64 host? Does 'yum install kernel' do the right thing? x86_64 host.
> Does 'yum install kernel' do the right thing?
Seems to:
[mclasen@planemask gnome-panel-2.26.2]$ sudo yum install kernel
Loaded plugins: dellsysidplugin2, presto, refresh-packagekit
Setting up Install Process
Package kernel-2.6.31-0.28.rc1.fc12.x86_64 already installed and latest version
Nothing to do
This is broken by commit 5216a27d35d60e46f028b1fbba58acae5b9e79d2 in yum -- if you initially set up without any repos (==> len(ayum.pkgSack)=0) and then add repos, yum no longer adds to the pkgSack on the first access with the new repos. It's a side effect, but it's a side effect that both livecd-creator and anaconda depend on working (and thus, probably that other tools do as well) Crap ... this just went into the RHEL-5.4 candidate too.
Ok, so here's what I think we can do (to fix both bugs):
commit 0e9c56de28596bad95c13fee15187df3249f4be1
Author: James Antill <james>
Date: Fri Jun 26 12:51:12 2009 -0400
Re-setup the pkgSack whenever the sacks change
diff --git a/yum/__init__.py b/yum/__init__.py
index be98aae..ef793f6 100644
--- a/yum/__init__.py
+++ b/yum/__init__.py
@@ -480,8 +480,11 @@ class YumBase(depsolve.Depsolve):
"""populates the package sacks for information from our repositories,
takes optional archlist for archs to include"""
- if self._pkgSack is not None and thisrepo is None:
+ pkgSack_count = len(self.repos.pkgSack.sacks)
+ if (self._pkgSack is not None and
+ pkgSack_count == self._old_pkgSack_count and thisrepo is None):
return self._pkgSack
+ self._old_pkgSack_count = pkgSack_count
if thisrepo is None:
repos = 'enabled'
...can you confirm, if so I'll puch it everywhere.
Ok, that's insane ... because the sacks come from populateSacks, which is inside that function ... I think the only way we can do this is test to see if listEnabled() has changed. Probably the fastest way to do that is put some timestamp in the repos object, and then check if timestamp == old_timestamp. How about we fix the problem separately in package-cleanup and not modify yum? It's not just package-cleanup that hits it, it also hit at least versionlock ... and generally anything 485578 that uses .pkgSack when they are empty due to excludes (I think). I'm also not sure how we can fix it at a higher level. I've pushed a patch which is almost all comment and I think fixes it with no bad side effects ... Jeremy can you have a look? http://yum.baseurl.org/gitweb?p=yum.git;a=commitdiff;h=06e7d4492846f30d03e400d795bd353bdac6ab77 Yep, I'm on top form ... I pasted the above BZ number into the wrong place and pushed the commit without adding it to the summary. I shall now go drink some cherry coke and wait for my holiday to start. The patch in comment 8 at least allows livecd-creator to get to the point where it falls over broken dependencies in rawhide. I guess thats progress... Can we get this patch in rawhide to make some progress towards buildable live cds ? yes. I'll put something in today. yum-3.2.23-9.fc12 which should be in koji, now, has this patch. Please let me know if it does not correct the problem for you Looking okay |