Bug 508232

Summary: SAF Test lck: saLckResourceClose/3-1.c
Product: [Fedora] Fedora Reporter: Jan Friesse <jfriesse>
Component: openaisAssignee: Ryan O'Hara <rohara>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: agk, fdinitto, sdake
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-06-29 19:23:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Don't assume a callback has been made until it is actually called. none

Description Jan Friesse 2009-06-26 09:42:39 UTC 
Description of problem:
Test in SUBJ doesn't work

Version-Release number of selected component (if applicable):
Trunk

How reproducible:
Run it

Steps to Reproduce:
1.
2.
3.

Actual results:
select error!

Expected results:
Test runs ok

Additional info:
It looks like saLckResourceClose doesn't cancel pending request lock
Comment 1 Ryan O'Hara 2009-06-29 17:32:37 UTC 
This is a bug in the saftest code. The test code assumes that if select returns a value > 0, a callback has been made. That isn't true, at least for OpenAIS. I will attach a new version of the test case that doesn't depend on select to determine is a callback has been made.
Comment 2 Ryan O'Hara 2009-06-29 17:33:41 UTC 
Created attachment 349827 [details]
Don't assume a callback has been made until it is actually called.

This code appears to fix the test case in question.
Comment 3 Ryan O'Hara 2009-06-29 19:23:14 UTC 
Closing this as fixed upstream. OpenAIS lock service now has code to cancel/skip callbacks for resources that have been closed with pending callbacks. Fix for saftest code it attached above.