Bug 508349
Summary: | Review Request: kdepim-runtime - KDE PIM Runtime Environment | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Than Ngo <than> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-26 20:27:09 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Than Ngo
2009-06-26 17:05:33 UTC
Some quick comments: 0. drop the epoch, this is a new pkg 1. missing desktop-file-install/desktop-file-validate 2. missing icon/mime scriptlets 3. do we really want/need Provides: kdepim4 = %{version}-%{release} here? 4. Source URL is wrong (s/stable/unstable), but that's minor >0. drop the epoch, this is a new pkg it's fixed >1. missing desktop-file-install/desktop-file-validate is it really required to use desktop-file-install/desktop-file-validate? >2. missing icon/mime scriptlets add missing update-mime-database, it's fixed >3. do we really want/need >Provides: kdepim4 = %{version}-%{release} >here? it's not needed, drop it >4. Source URL is wrong (s/stable/unstable), but that's minor it's fixed new specs and srpm uploaded Yes, 1, is needed, for items under /usr/share/applications/, but we can deal with that post-review, I won't consider it a blocker for now. Ah, I see you added it, good. The rest looks good now, can't test buildability/runtime yet, but we'll deal with that when the rest of kde-4.3-rc2 is built. APPROVED. New Package CVS Request ======================= Package Name: kdepim-runtime Short Description: KDE PIM Runtime Environment Owners: than Branches: F-10 F-11 InitialCC: CVS done. |