Bug 508349

Summary: Review Request: kdepim-runtime - KDE PIM Runtime Environment
Product: [Fedora] Fedora Reporter: Than Ngo <than>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-26 20:27:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Rex Dieter 2009-06-27 02:01:22 UTC
Some quick comments:

0. drop the epoch, this is a new pkg

1.  missing desktop-file-install/desktop-file-validate

2.  missing icon/mime scriptlets

3.  do we really want/need
Provides: kdepim4 = %{version}-%{release}
here?

4.  Source URL is wrong (s/stable/unstable), but that's minor

Comment 2 Than Ngo 2009-06-29 11:28:24 UTC
>0. drop the epoch, this is a new pkg
it's fixed

>1.  missing desktop-file-install/desktop-file-validate
is it really required to use desktop-file-install/desktop-file-validate?

>2.  missing icon/mime scriptlets
add missing update-mime-database, it's fixed

>3.  do we really want/need
>Provides: kdepim4 = %{version}-%{release}
>here?
it's not needed, drop it

>4.  Source URL is wrong (s/stable/unstable), but that's minor  
it's fixed

new specs and srpm uploaded

Comment 3 Rex Dieter 2009-06-29 13:32:17 UTC
Yes, 1, is needed, for items under /usr/share/applications/,

but we can deal with that post-review, I won't consider it a blocker for now.

Comment 4 Rex Dieter 2009-06-29 13:34:54 UTC
Ah, I see you added it, good.

The rest looks good now, can't test buildability/runtime yet, but we'll deal with that when the rest of kde-4.3-rc2 is built.

APPROVED.

Comment 5 Than Ngo 2009-06-29 14:22:17 UTC
New Package CVS Request
=======================
Package Name: kdepim-runtime
Short Description: KDE PIM Runtime Environment
Owners: than
Branches: F-10 F-11
InitialCC:

Comment 6 Jason Tibbitts 2009-06-29 17:08:58 UTC
CVS done.