Bug 508991

Summary: remove rhpl usage
Product: [Fedora] Fedora Reporter: Jeremy Katz <katzj>
Component: system-config-firewallAssignee: Thomas Woerner <twoerner>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: tcallawa, twoerner
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-14 12:54:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 508951    
Attachments:
Description Flags
untested patch none

Description Jeremy Katz 2009-06-30 18:33:25 UTC 
system-config-firewall only depends on rhpl for rhpl.translate, but is actually only working through a bit of an accident at present.

The usual case is to replace imports of rhpl.translate for _ and N_ with
  import gettext
  _ = lambda x: gettext.ldgettext(domain, x)
  N_ = lambda x: x 

system-config-firewall only does the import in one place (fw_config), but 
  from fw_config import *
doesn't actually put _ in your namespace as _ is a reserved character.  s-c-firewall ends up getting translations just because it also imports part of system-config-network which does a global override of the _ builtin.
Comment 1 Jeremy Katz 2009-06-30 18:39:52 UTC 
Created attachment 350003 [details]
untested patch

Here's an (untested) patch that I think should fix things up for you and switch to not using rhpl in the process
Comment 2 Thomas Woerner 2009-09-02 13:08:38 UTC 
Fixed in git: http://git.fedorahosted.org/git/system-config-firewall.git?p=system-config-firewall.git;a=commit;h=9c1129ca3b8c5c10050f36a26676ddab207907eb

Will be part of next package.