Bug 509159 (PragmARC)
| Summary: | Review Request: PragmARC – a component library for Ada | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Björn Persson <bjorn> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-02 02:29:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 507247, 509158 | ||
| Bug Blocks: | 509160 | ||
|
Description
Björn Persson
2009-07-01 15:29:52 UTC
Updated to require fedora-gnat-project-common: http://www.rombobjörn.se/packages/PragmARC.spec http://www.rombobjörn.se/packages/PragmARC-20060427-2.fc11.src.rpm Apparently the buildroot tag is still required for bureaucratic reasons, so I added one. http://www.rombobjörn.se/packages/PragmARC.spec http://www.rombobjörn.se/packages/PragmARC-20060427-3.fc11.src.rpm Updated the URLs because the PragmAda site moved: http://www.rombobjörn.se/packages/PragmARC.spec http://www.rombobjörn.se/packages/PragmARC-20060427-4.fc11.src.rpm unblocking FE-NEEDSPONSOR - I just sponsored Björn Persson. I'll review it. Koji successful scratchbuild for F-11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1776218 Sources, used to build package, are matching upstream ones: [petro@Sulaco SOURCES]$ sha256sum pragmarc.zip* 6c80906ed7b64fb1c065f1a7a9331fa644ce1c2f34e807dd794d74db92201da9 pragmarc.zip 6c80906ed7b64fb1c065f1a7a9331fa644ce1c2f34e807dd794d74db92201da9 pragmarc.zip.1 [petro@Sulaco SOURCES]$ REVIEW: + rpmlint is silent: [petro@Workplace tmp]$ rpmlint PragmARC- PragmARC-20060427-4.fc11.i586.rpm PragmARC-debuginfo-20060427-4.fc11.i586.rpm PragmARC-devel-20060427-4.fc11.i586.rpm [petro@Workplace tmp]$ rpmlint PragmARC-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. [petro@Workplace tmp]$ + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec . + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. (GPL with exceptions) + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package are matching the upstream source. + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. + The package (or subpackage) calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + Anything, the package includes as %doc, does not affect the runtime of the application. + Development-related files are in a -devel package. + The library file that end in .so (without suffix) is in a -devel package. [20] + The devel sub-package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. APPROVED. Thanks for the review! New Package CVS Request ======================= Package Name: PragmARC Short Description: PragmAda Reusable Components, a component library for Ada Owners: rombobeorn Branches: F-11 F-12 InitialCC: cvs done. PragmARC-20060427-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/PragmARC-20060427-5.fc11 Package imported, closing. PragmARC-20060427-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/PragmARC-20060427-6.fc11 PragmARC-20060427-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/PragmARC-20060427-6.fc12 PragmARC-20060427-6.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. PragmARC-20060427-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: PragmARC New Branches: el6 Owners: rombobeorn Git done (by process-git-requests). |