Bug 509313

Summary: Review Request: perl-CGI-Application-Plugin-FillInForm - Integrate CGI::Application with HTML::FillInForm
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.14-1.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-16 07:33:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2009-07-02 06:59:27 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-FillInForm/perl-CGI-Application-Plugin-FillInForm.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-FillInForm/perl-CGI-Application-Plugin-FillInForm-1.14-1.fc11.src.rpm
Description:
This plugin for CGI::Application provides a mix-in method to make using
HTML::FillInForm more convenient.

Comment 1 Parag AN(पराग) 2009-07-03 04:48:21 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452073
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
46e4ad333fdfdaa85f0eabc72a14ecce254326ca  CGI-Application-Plugin-FillInForm-1.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=35,  0 wallclock secs ( 0.04 usr  0.00 sys +  0.16 cusr  0.04 csys =  0.24 CPU)
+ Package perl-CGI-Application-Plugin-FillInForm-1.14-1.fc12.noarch =>
Provides: perl(CGI::Application::Plugin::FillInForm) = 1.14
Requires: perl(Carp) perl(Exporter) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.

Comment 2 Emmanuel Seyman 2009-07-03 09:19:50 UTC
(In reply to comment #1)
>
> APPROVED.  

Thanks, Parag. Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-CGI-Application-Plugin-FillInForm
Short Description: Integrate CGI::Application with HTML::FillInForm
Owners: eseyman
Branches: F-11 F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-07-06 04:08:25 UTC
cvs done.

Comment 4 Fedora Update System 2009-07-06 09:30:30 UTC
perl-CGI-Application-Plugin-FillInForm-1.14-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-FillInForm-1.14-1.fc11

Comment 5 Fedora Update System 2009-07-11 17:28:42 UTC
perl-CGI-Application-Plugin-FillInForm-1.14-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-FillInForm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7509

Comment 6 Fedora Update System 2009-07-16 07:33:19 UTC
perl-CGI-Application-Plugin-FillInForm-1.14-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.