Bug 509670
Summary: | Review Request: compat-libgdamm - compat libs for libgdamm-3 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Hicham HAOUARI <hicham.haouari> |
Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | debarshir, fedora-package-review, leigh123linux, notting, nushio, tcallawa |
Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 3.0.1-3.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-08-07 05:07:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 509744 |
Description
Hicham HAOUARI
2009-07-04 21:53:25 UTC
You will need to fix this. [leigh@localhost Desktop]$ rpmlint '/home/leigh/Desktop/compat-libgdamm-3.0.1-2.fc11.src.rpm' error checking signature of /home/leigh/Desktop/compat-libgdamm-3.0.1-2.fc11.src.rpm compat-libgdamm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 1) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [leigh@localhost Desktop]$ Fixed the warning. Spec URL: http://hicham.iblogger.org/linux/fedora/releases/11/Everything/source/SPECS/compat-libgdamm.spec SRPM URL: http://hicham.iblogger.org/linux/fedora/releases/11/Everything/source/SRPMS/compat-libgdamm-3.0.1-2.fc11.src.rpm Koji build page : https://koji.fedoraproject.org/koji/taskinfo?taskID=1454719 Hey. Per our conversation on IRC, I will take a look at reviewing this package and sponsoring you. I'm adding spot here in CC. He's the maintainer of the current libgdamm package. I just want to make sure he has no objection to you maintaining a compat package here. ;) Look for a review in a bit. Compat libs of libgdamm are needed for what exactly? compat libs of libgdamm are needed for solang : https://bugzilla.redhat.com/show_bug.cgi?id=509744 After discussion on IRC, I have no problems with the existence of a compat-libgdamm, as long as it is properly end-of-lifed when it is no longer needed by solang, under the assumption that solang will eventually move to the libgdamm 4.0 API. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 63583ec970e643962474401400e19994 libgdamm-3.0.1.tar.bz2 63583ec970e643962474401400e19994 libgdamm-3.0.1.tar.bz2.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Headers/static libs in -devel subpackage. OK - Spec has needed ldconfig in post and postun OK - .pc files in -devel subpackage/requires pkgconfig OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: compat-libgdamm-devel.x86_64: W: no-documentation This can be ignored. I don't see any blockers here, so this package is APPROVED. New Package CVS Request ======================= Package Name: compat-libgdamm Short Description: C++ wrappers for libgda3 Owners: hicham Branches: F-11 InitialCC: hicham cvs done. compat-libgdamm-3.0.1-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update compat-libgdamm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7733 compat-libgdamm-3.0.1-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |