Bug 509933

I built this and noted that the python module isn't in the usual place for python modules, which ends up causing the files to not be byte-compiled.  This could cause problems if, for example, root runs the program and python decides to byte-compile the module then.  This used to be an issue, but I don't really know enough about python to know if it still is or what to do about it.

OK, the problem was that python isn't in the build root.  Adding
  BuildRequires: python
fixes it.

You should also use %{_datadir} instead of hardcoding /usr/share and use cp -p to copy your files so the timestamps are preserved.

(In reply to comment #1)
> I built this and noted that the python module isn't in the usual place for
> python modules, which ends up causing the files to not be byte-compiled.  This
> could cause problems if, for example, root runs the program and python decides
> to byte-compile the module then.  This used to be an issue, but I don't really
> know enough about python to know if it still is or what to do about it. 

Hey Jason -- thanks for the review :)

I believe that installing chameleon in /usr/share/ is more appropriate then site-packages because chameleon is an application and not an extension to python libs (packages).

(In reply to comment #2)
> OK, the problem was that python isn't in the build root.  Adding
>   BuildRequires: python
> fixes it.
> 
> You should also use %{_datadir} instead of hardcoding /usr/share and use cp -p
> to copy your files so the timestamps are preserved.  

Great comments.  Thanks.

Applied in http://svn.fedorahosted.org/svn/chameleon/trunk/chameleon.spec and https://fedorahosted.org/releases/c/h/chameleon/chameleon-0.1-7.fc10.src.rpm.

For testing, the .sql files in http://svn.fedorahosted.org/svn/chameleon/trunk/samples can be used.

help:
  chameleon -h

try:

wget http://svn.fedorahosted.org/svn/chameleon/trunk/samples/sample.sql 
chameleon -s postgres sample.sql
chameleon -s oracle sample.sql

Planning on including a man page and documentation on the wiki more information in the README.

Just went to review this, but the spec above doesn't match the src.rpm above.

(In reply to comment #6)
> Just went to review this, but the spec above doesn't match the src.rpm above.  

This: https://fedorahosted.org/releases/c/h/chameleon/chameleon-0.2-1.fc10.src.rpm matches.

It's odd that rpm doesn't generate a python(abi) dependency for this package, but I guess that's because the modules aren't in the usual location for python modules.  I don't think that causes any problems, because as far as I know even the .pyc and .pyo files are compatible between python versions.

Otherwise, this builds fine and rpmlint is silent.  The web site is a little sparse but I assume someone will take care of that as the software is developed further.  I don't see any issues with the package.

* source files match upstream.  sha256sum:
   e70e8fa4cf67467f9ad90be0ee92479234e594306a638cc548c4150af96b189c
   chameleon-0.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   chameleon = 0.2-1.fc12
  =
   /usr/bin/env
   python >= 2.3
   python-ply

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Thanks for the review Jason :)

Since chameleon is an application (tool) rather then an extension of python libs, it seemed inappropriate to install in site-packages.  After review of several other python tools, including RHN, /usr/share seemed to be consistent with other projects.

As for the trac wiki, you're right, it's very sparse.  This tool is a build requirement for the Fedora Spacewalk project and I needed to get this out there ASAP.  I intend to provide a rich wiki, documentation and epydocs for the code in the coming weeks.

New Package CVS Request
=======================
Package Name: chameleon
Short Description: Database schema transformation tool.
Owners: jortel
Branches: F-10 F-11 EL-4 EL-5
InitialCC: jortel

cvs done.

chameleon-0.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/chameleon-0.2-1.fc11

chameleon-0.2-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/chameleon-0.2-1.fc10

chameleon-0.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

chameleon-0.2-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.