Bug 510104

Summary: Review Request: epic5 - an ircII chat client
Product: [Fedora] Fedora Reporter: John Roman <nimbius>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, jan.klepek, notting, randyn3lrx, susi.lehtola, vcrhonek, wolfy
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-05 11:48:35 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description John Roman 2009-07-07 13:31:27 EDT
Spec URL: http://nimbius.36bit.com/epic5.spec
SRPM URL: http://nimbius.36bit.com/epic5-1.0-1.fc11.src.rpm
Description: epic5 is the latest version of Epic, a chat client based on the ircII client.
Comment 1 Bill Nottingham 2009-07-07 13:57:36 EDT
Why not just upgrade the existing version?
Comment 2 Susi Lehtola 2009-07-08 05:21:47 EDT
vcrhonek: what do you think?
Comment 3 John Roman 2009-07-08 09:37:27 EDT
I mentioned an upgrade to the last user cited in the changelog for epic4, but no response.  4 and 5 are similar, but their scripts are not compatible.
Comment 4 Randall "Randy" Berry 2009-07-10 02:01:25 EDT
spec file is a mess use macros instead of hard coded path.

http://www.fedoraproject.org/wiki/Packaging:RPMMacros
/usr/share/epic5/script/ should be %{_datadir}/%{name}/script

Package must own all directories it creates.

http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership
use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script


Shorten list by using %{_datadir}/%{name}/script/*

No %changelog entry

Package does not build as is.
Comment 5 Susi Lehtola 2009-07-10 04:31:09 EDT
(In reply to comment #4)
> spec file is a mess use macros instead of hard coded path.
> 
> http://www.fedoraproject.org/wiki/Packaging:RPMMacros
> /usr/share/epic5/script/ should be %{_datadir}/%{name}/script
> 
> Package must own all directories it creates.
> 
> http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership
> use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script
> 
> Shorten list by using %{_datadir}/%{name}/script/*

Yes, it seems to be rather a mess. %{_datadir}/epic5/ should be owned too, so the files section would end up as

%{_bindir}/epic5
%{_bindir}/epic5-1.0
%{_datadir}/epic5/
%{_mandir}/man1/epic5.1.*
%{_libexecdir}/epic5-wserv4 <- add trailing slash if this is a directory


- The Requires
Requires:      ncurses-devel >= 5.7-2
Requires:      ruby-devel    >= 1.8.6
Requires:      perl-ExtUtils-Embed >= 1.28-69 
should be BuildRequires. Also, you probably need perl-devel.

- Contact upstream so that they fix SMP make.

- The install command should be
make install IP=$RPM_BUILD_ROOT INSTALL_PROGRAM="install -c -p -m 755" INSTALL_DATA="install -c -p -m 644"
to preserve time stamps (OK, not essential for the binaries). I have no idea why make install compiles some test program, but it isn't installed so the optflags are not needed in install.

- You could also ask upstream to change IP to the standard DESTDIR in the makefile.
Comment 6 John Roman 2009-07-10 09:10:04 EDT
Thanks very much for the valuable input! and sorry for wasting time by not reading the aforementioned docs.   

upstream maintainer has been warned of bugs, and im rebuilding the spec file to look less like the taco bell value menu.
Comment 7 Jan Klepek 2009-07-19 07:35:01 EDT
Hi,

Is this your first package? 
I'm unable to find you in packager group nor any other package review request
from you.
If yes, please go ahead
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account
and put FE-NEEDSPONSOR into Blocks field.
if no, what is your FAS username?
Comment 8 John Roman 2009-07-19 13:05:04 EDT
applied in accordance with requirements at the given url.
blocks field populated.  anxiety abounds. 

still waiting on the upstream to fix SMP make...
Comment 9 Jan Klepek 2009-08-05 09:07:43 EDT
please don't use full path to files like:
/usr/share/epic5/script/...
which is in your %files section, use appropriate macro
Comment 10 Jan Klepek 2009-08-29 03:42:27 EDT
any update?
Comment 11 John Roman 2009-08-31 23:56:31 EDT
debugging the smp build fail with devs at epic.  cleaning up my .spec so it builds on more than my pc.
Comment 12 Mamoru TASAKA 2009-09-15 13:52:52 EDT
What is the status of this bug?
Comment 13 manuel wolfshant 2010-07-21 18:46:40 EDT
anything new or should we just close the bug?
Comment 14 manuel wolfshant 2010-07-27 09:58:17 EDT
will close the bug in one week unless we have an update by then.
Comment 15 Mamoru TASAKA 2010-08-05 11:48:35 EDT
(In reply to comment #14)
> will close the bug in one week unless we have an update by then.    

Closing as one week passed.

If someone wants to import this package into Fedora, please submit
a new review request and mark this bug as a duplicate of the new
one, thank you.