Bug 510576
Summary: | still requires usermode for gnome-about-me | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> | ||||
Component: | control-center | Assignee: | Control Center Maintainer <control-center-maint> | ||||
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 11 | CC: | control-center-maint, mclasen, rstrode, rvokal | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-07-24 14:46:11 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Bill Nottingham
2009-07-09 19:59:05 UTC
Also, switching back appears to fix both bug 484786 and bug 235484. Working on it. Unfortunately, the upstream code does not work so hot, either. It scrapes the output or /usr/bin/passwd, but it can't understand half of what our passwd has to say. Plus, for some reason that I haven't been able to figure out yet, out passwd runs into SIGPIPE instead of exiting regularly. The attached patch has a workaround for that. Created attachment 354939 [details]
patch
So, looking at the upstream code it's not really suitable to use: 1) Screenscraping /usr/bin/passwd is fundamentally broken. It will always fail in some cases, because different users have different pam modules, different users have different translations, and the existing pam module strings get updated once in a while. 2) The code races with itself in various places (handles sigchld before reading all of stdin, etc) 3) The code calls SIGKILL on passwd. We could fix 2 and 3, but 1 is going to be a continual ongoing problem. We could make gnome-about-me use libpam or libuser, but we're eventually going to drop about me anyway, so probably not worth the time investment. |