Bug 510808
| Summary: | Review Request: pondus - A personal weight management program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.5.3-2.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-29 22:58:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Susi Lehtola
2009-07-10 21:10:49 UTC
Did you consider a dependency on python-matplotlib? Without it you can't actually plot anything, and the description probably needs to account for that. Also, the message printed when you don't have python-matplotlib doesn't really help the user to figure out what package to install. (It references "Matplotlib", which you can search for, but it would be better if it indicated the package name.) I don't think that's a blocker, but do think of the users. * source files match upstream. sha256sum: 5b5dcecd570d2242663771f23d5d7679164fb04a82accf6a142b78bf485c1181 pondus-0.5.3.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: pondus = 0.5.3-1.fc12 = /usr/bin/python python(abi) = 2.6 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop files valid and installed properly. APPROVED Thanks for the review, and for spotting the missing req! New Package CVS Request ======================= Package Name: pondus Short Description: A personal weight management program Owners: jussilehtola Branches: F-10 F-11 InitialCC: Actually, I think I want the EPEL 5 branch as well. New Package CVS Request ======================= Package Name: pondus Short Description: A personal weight management program Owners: jussilehtola Branches: EL-5 F-10 F-11 InitialCC: CVS done. pondus-0.5.3-3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/pondus-0.5.3-3.el5 pondus-0.5.3-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/pondus-0.5.3-2.fc10 pondus-0.5.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pondus-0.5.3-2.fc11 pondus-0.5.3-3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pondus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0067 pondus-0.5.3-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pondus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-7564 pondus-0.5.3-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pondus'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7681 pondus-0.5.3-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. pondus-0.5.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. pondus-0.5.3-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |