Bug 510994
| Summary: | Review Request: gtg - Personal organizer for the GNOME desktop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanko Kaneti <yaneti> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | benjamin.podszun, fedora-package-review, notting, panemade, peter.hutterer |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-16 08:38:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yanko Kaneti
2009-07-13 05:14:42 UTC
1)Follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache 2) why not to use desktop-file-install? See http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage 3) you should use %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT 4) You can remove shebang in %prep as sed -i -e "s|#!/usr/bin/env python||" GTG/gtg.py (In reply to comment #1) > 1)Follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache Replaced with the ones from the snippets > 2) why not to use desktop-file-install? > See > http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage Included the validate snippet. > 3) you should use > %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT Ok. > 4) You can remove shebang in %prep as > sed -i -e "s|#!/usr/bin/env python||" GTG/gtg.py Ok. Although I think its best to leave upstream sources pristine unless it results in some package breakage. SPEC: http://declera.com/~yaneti/gtg/gtg.spec SRPM: http://declera.com/~yaneti/gtg/gtg-0.1.2-1.fc12.src.rpm * Mon Jul 13 2009 Yanko Kaneti <yaneti> 0.1.2-2 - Implement review feedback https://bugzilla.redhat.com/show_bug.cgi?id=510994#c1 Thanks SRPM: http://declera.com/~yaneti/gtg/gtg-0.1.2-2.fc12.src.rpm obviously. Sorry for the spam. SPEC: http://declera.com/~yaneti/gtg/gtg.spec SRPM: http://declera.com/~yaneti/gtg/gtg-0.1.2-3.fc12.src.rpm * Tue Jul 14 2009 Yanko Kaneti <yaneti> 0.1.2-3 - Use %%{__python} instead of python Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1474632 + rpmlint is silent for SRPM and for RPM. + source files match upstream url fadea48aa04227eb92b496bec66a4f912823fcf0 gtg-0.1.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + gtk-update-icon-cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI application APPROVED. New Package CVS Request ======================= Package Name: gtg Short Description: Personal organizer for the GNOME desktop Owners: yaneti Branches: F-10 F-11 InitialCC: cvs done. Imported. Builds done. Bodhi updates pending. Thanks for the review. Anyone keen to co-maintain please apply in pkgdb. |