Bug 511081
| Summary: | Review Request: perl-accessors - Create accessor methods in caller's package | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
| Component: | Package Review | Assignee: | Rasmus Ory Nielsen <ron> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, ron |
| Target Milestone: | --- | Flags: | ron:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-07-14 09:42:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 498969, 511094 | ||
|
Description
Daniel Berrangé
2009-07-13 15:25:42 UTC
Package builds fine and rpmlint is silent.
* source files match upstream:
sha256sum: 3a8db00f38148f3afadbe5330dc5490d9933f9cae137e842ec225a4d3adb2d9f
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
Note, %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) is
preferred over the one used, see
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock.
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
perl(accessors) = 1.01
perl(accessors::chained) = 1.01
perl(accessors::classic) = 1.01
perl(accessors::ro) = 1.01
perl(accessors::rw) = 1.01
perl-accessors = 1.01-1.fc10
---
perl >= 0:5.006
perl(:MODULE_COMPAT_5.10.0)
perl(base)
perl(constant)
perl(strict)
perl(warnings::register)
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
New Package CVS Request ======================= Package Name: perl-accessors Short Description: Create accessor methods in caller's package Owners: berrange Branches: F-11 InitialCC: perl-sig cvs done. Built into rawhide as perl-accessors-1.01-1.fc12 perl-accessors-1.01-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-accessors-1.01-1.fc11 perl-accessors-1.01-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |