Bug 511131
| Summary: | Do not return comment activity in bugzilla.getBug() since special characters sometimes crashes XMLRPC::Lite | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] Bugzilla | Reporter: | David Lawrence <dkl> | ||||
| Component: | WebService | Assignee: | David Lawrence <dkl> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 3.2 | CC: | kbaker, mikeb | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-07-20 15:03:42 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Patch looks simple enough. Is there a long term solution? Perhaps a patch to XMLRPC::Lite? There is talk upstream about moving away from XMLRPC::Lite for various reasons. Most that it is cryptic to read and maintain and also unstable. There is talk to move over to RPC::XML and is being tracked here: https://bugzilla.mozilla.org/show_bug.cgi?id=475086 Most fixes in the past to SOAP::Lite was to override the methods with fixed ones in the Bugzilla WebService modules. Dave Comment on attachment 351515 [details]
Patch to remove comment activity in bugzilla.getBug() (v1)
patch looks good Dave.
Thanks,
Noura
Thanks Noura. Committed. |
Created attachment 351515 [details] Patch to remove comment activity in bugzilla.getBug() (v1) Description of problem: Bugzilla has some comments that have garbage characters embedded in them and causes XMLRPC::Lite to crash when using bugzilla.getBug(). You can now edit the comments to remove the problem characters but currently bugzilla.getBug() returns the comment activity as well so this still causes the crash with the old comments. The patch attached removes the activity from comments return by bugzilla.getBug() for now. Bug.get() is not affected as we do not yet return any comments using that method. When that method does return comments, I propose we take an additional param that allows a user to explicitly ask for the comment history, otherwise do not return by default. Please review Dave