Bug 513150
| Summary: | Review Request: bios_extract - Tool to extract the different submodules of common legacy bioses | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0-0.4.20090713git.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-05 17:23:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Lemenkov
2009-07-22 09:16:09 UTC
- Verified the source matches upstream - The License matches upstream source file headers. APPROVED little nitpicking - The release starting with 0. is redundant to version 0. , would use just 1.whatever - cgit on fdo is nice. I would use Source0: http://cgit.freedesktop.org/~libv/bios_extract/snapshot/bios_extract-%{git_commit}.tar.bz2 - Having at least two executables , perhaps s/Tool/Tools/ everywhere. (In reply to comment #1) > - Verified the source matches upstream > - The License matches upstream source file headers. > > APPROVED Thanks! > little nitpicking > > - The release starting with 0. is redundant to version 0. , would use just > 1.whatever I'm afraid, I can't do this. There are no such exceptions in Fedora Packaging Guidelines regarding versioning of packages, based on VCS's snapshots. Anyway, it's not a big issue. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages > - cgit on fdo is nice. I would use > Source0: > http://cgit.freedesktop.org/~libv/bios_extract/snapshot/bios_extract-%{git_commit}.tar.bz2 Thanks for the tip! I didn't know about such feature. Fixed. > - Having at least two executables , perhaps s/Tool/Tools/ everywhere. Done. http://peter.fedorapeople.org/bios_extract.spec http://peter.fedorapeople.org/bios_extract-0-0.2.20090713git.fc11.src.rpm Again looks fine. Please do the cvs incantation :) New Package CVS Request ======================= Package Name: bios_extract Short Description: Tools to extract the different submodules of common legacy bioses Owners: peter Branches: EL-4 EL-5 F-10 F-11 InitialCC: CVS done. bios_extract-0-0.2.20090713git.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/bios_extract-0-0.2.20090713git.fc10 bios_extract-0-0.2.20090713git.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/bios_extract-0-0.2.20090713git.el5 bios_extract-0-0.2.20090713git.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/bios_extract-0-0.2.20090713git.fc11 bios_extract-0-0.2.20090713git.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/bios_extract-0-0.2.20090713git.el4 bios_extract-0-0.2.20090713git.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0116 bios_extract-0-0.2.20090713git.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-4/FEDORA-EPEL-2009-0095 bios_extract-0-0.2.20090713git.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7992 bios_extract-0-0.2.20090713git.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8005 bios_extract-0-0.4.20090713git.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/bios_extract-0-0.4.20090713git.fc11 bios_extract-0-0.4.20090713git.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/bios_extract-0-0.4.20090713git.fc10 bios_extract-0-0.4.20090713git.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8246 bios_extract-0-0.4.20090713git.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bios_extract'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8250 bios_extract-0-0.2.20090713git.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. bios_extract-0-0.2.20090713git.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. bios_extract-0-0.4.20090713git.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. bios_extract-0-0.4.20090713git.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |