Bug 513419

Summary:	gimp plugins not unprelinked correctly
Product:	[Fedora] Fedora	Reporter:	Bradley <bbaetz>
Component:	gimp	Assignee:	Nils Philippsen <nphilipp>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	11	CC:	jakub, nphilipp
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-07-24 15:00:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	512618
Bug Blocks:

Description Bradley 2009-07-23 15:11:24 UTC

Description of problem:

The various plugins from gimp-2.6.6-6.fc11.x86_64 (and previous F11 version) don't unprelink to be the same as the original file.

Version-Release number of selected component (if applicable):

gimp-2.6.6-6.fc11.x86_64
prelink-0.4.0-7.fc11.x86_64
binutils-2.19.51.0.2-17.fc11.x86_64

How reproducible:

Always

Steps to Reproduce:
1. Install gimp-2.6.6-6.fc11.x86_64
2. run the prelink cronjob
3. rpm -V gimp

OR

2. Take a copy of a plugin (I used /usr/lib64/gimp/2.0/plug-ins/red-eye-removal)
3. Run prelink /usr/lib64/gimp/2.0/plug-ins/red-eye-removal
4. Run prelink -u /usr/lib64/gimp/2.0/plug-ins/red-eye-removal
5. md5sum red-eye-removal red-eye-removal.orig

Actual results:

rpm -V fails, with lots of:

prelinked file was modified

d695f2a8af86c12179aee06e71a1a6fa  red-eye-removal
7181c148b7075f9139da4357093a2fd6  red-eye-removal.orig

Expected results:

rpm -V works, files end up being the same

Additional info:

deltarpm can't be applied. Also see bug 450710, which was the same problem with the seahorse package in F9 (no longer present in F11)

diffs of |readelf -a| shows a single difference - the last dynamic section has tag 0x0, and originally has a value of 0x401046 (same as the previous VERSYM section), but afterwards it has a value of 0.

diff of |od| over the whole file is:

--- od.orig     2009-07-24 01:01:38.000000000 +1000
+++ od.new      2009-07-24 01:01:33.000000000 +1000
@@ -741,8 +741,7 @@
 0031520 177776 067777 000000 000000 010320 000100 000000 000000
 0031540 177777 067777 000000 000000 000001 000000 000000 000000
 0031560 177760 067777 000000 000000 010106 000100 000000 000000
-0031600 000000 000000 000000 000000 010106 000100 000000 000000
-0031620 000000 000000 000000 000000 000000 000000 000000 000000
+0031600 000000 000000 000000 000000 000000 000000 000000 000000
 *
 0032020 000000 000000 000000 000000 030300 000140 000000 000000
 0032040 000000 000000 000000 000000 000000 000000 000000 000000

Comment 1 Jakub Jelinek 2009-07-24 09:15:34 UTC

By any chance, isn't chrpath --delete used to create the plugins?
If yes, this is a dup of chrpath's bug #512618.

Comment 2 Bradley 2009-07-24 10:13:30 UTC

Yeah, looks like it:

# remove rpaths
find %buildroot -type f -print0 | xargs -0 -L 20 chrpath --delete --keepgoing 2>/dev/null || :

*** This bug has been marked as a duplicate of bug 512618 ***

Comment 3 Bradley 2009-07-24 10:21:24 UTC

Not sure why the other packages that use chrpath (eg boost) aren't affected, but....

gimp should probably rebuilt when the chrpath bug is fixed so that |rpm -V| works

Comment 4 Axel Thimm 2009-07-24 10:51:47 UTC

Please try to rebuild with

https://admin.fedoraproject.org/updates/chrpath-0.13-5.fc11

Thanks!

Comment 5 Bradley 2009-07-24 12:10:30 UTC

Yep, that fixes it, thanks.

On second thoughts, reopening and reassigning to the gimp package so that this can get rebuilt once the chrpath change hits the koji buildroot.

Comment 6 Nils Philippsen 2009-07-24 15:00:13 UTC

I've only rebuilt this on Rawhide, not the released Fedora versions as this would only benefit those people using drpms and prelink where prelink hasn't been run on the binaries in the meantime. All other people (non-users of either drpms or prelink, those where prelink has been run in the meantime) would be forced to download the whole packages unnecessarily.