Bug 513848
| Summary: | Review Request: fbzx - A ZX Spectrum emulator for FrameBuffer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrea Musuruane <musuruan> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, hdegoede, lucilanga, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.1b-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-25 04:29:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrea Musuruane
2009-07-26 15:28:29 UTC
I'll review this. Full review done, results: MUST FIX: --------- * You (correcty IMHO, esp as the icon is zgv) include icon cache scriptlets, but you install the icon under /usr/share/pixmaps instead of under /usr/share/icons/hicolor/scalable/apps Don't forget to add a Requires: hicolor-icon-theme for dir ownership when you fix this SHOULD FIX: ----------- * Please use "install -p -m ..." instead of "install -m ..." when installing non generated files to preserve the timestamps (for the keymap.bmp and fbzx.svg files) Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/fbzx.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/fbzx-2.1b-2.fc10.src.rpm Changelog: - Icon is now installed into %%{_datadir}/icons/hicolor/scalable/apps - Added missing desktop-file-utils to BuildRequires - Added missing hicolor-icon-theme to Requires - Preserved timestamps Looks good now, approved! New Package CVS Request ======================= Package Name: fbzx Short Description: A ZX Spectrum emulator for FrameBuffer Owners: musuruan Branches: F-10 F-11 InitialCC: CVS done. fbzx-2.1b-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/fbzx-2.1b-2.fc11 fbzx-2.1b-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/fbzx-2.1b-2.fc10 fbzx-2.1b-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fbzx'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8646 fbzx-2.1b-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update fbzx'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8652 fbzx-2.1b-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. fbzx-2.1b-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |