Bug 513856

Summary: Restart notification is displayed for packages I did not update
Product: [Fedora] Fedora Reporter: Michael Cronenworth <mike>
Component: PackageKitAssignee: Richard Hughes <richard>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: milan.kerslager, rhughes, richard, smparrish
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-13 08:28:43 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
requested pkcon output none

Description Michael Cronenworth 2009-07-26 16:43:49 UTC 
Description of problem: PackageKit displays a list of updates. Qt is one of the updates. I uncheck Qt from updates and perform an update. Everything is updated except for Qt, but PackageKit places a notification icon saying I need to reboot because "qt" and "qt-x11" were updated, but they were not updated.


Version-Release number of selected component (if applicable): PackageKit-0.4.8-2.fc11.x86_64
qt-4.5.1-13.fc11.x86_64


How reproducible: Always


Steps to Reproduce:
1. Have qt (or any other package that requires reboot) updated
2. Uncheck it from updates.
3. Perform an update
  
Actual results: PackageKit thinks I need to reboot.


Expected results: No notification displayed.


Additional info:
Comment 1 Richard Hughes 2009-07-26 19:46:21 UTC 
What was the tooltip message exactly? I've applied the following to make things clearer when libraries in use trigger the message.

commit 5e155e1f0e6493bd8c8fb538b0548c527868e371
Author: Richard Hughes <richard>
Date:   Sun Jul 26 20:44:20 2009 +0100

    Don't print the package list when we have a RestartRequired of a security type
Comment 2 Michael Cronenworth 2009-07-27 04:04:05 UTC 
(In reply to comment #1)
> What was the tooltip message exactly? 

A restart is required
This is due to the following packages being updated: qt and qt-x11

That is character for character exact. Missing punctuation and all.
Comment 3 Richard Hughes 2009-07-27 07:17:41 UTC 
commit 0a342ec3179fc996cae9c78bff94d96d6324a71b
Author: Richard Hughes <richard>
Date:   Mon Jul 27 08:15:53 2009 +0100

    Add some missing punctuation in some of the restart strings

:100644 100644 c2a6750... 52af3d0... M  src/gpk-enum.c
:100644 100644 14d53ee... 7bf870f... M  src/gpk-watch.c

Could you also include the output of:

pkcon get-transactions | head -n 500

Thanks.
Comment 4 Michael Cronenworth 2009-07-28 00:14:41 UTC 
Created attachment 355341 [details]
requested pkcon output

This is on a machine that has not updated the qt packages in question, so let me know if you need anything else. Thanks.
Comment 5 Milan Kerslager 2009-07-28 04:06:54 UTC 
Even update failed, PackageKit demand restart (fileconflict in qt i586 and x86_64 packages here). IIRC when downloading of packages fails (and thus whole update fails), restart is demanded too.
Comment 6 Richard Hughes 2009-07-28 10:49:09 UTC 
(In reply to comment #5)
> Even update failed, PackageKit demand restart (fileconflict in qt i586 and
> x86_64 packages here). IIRC when downloading of packages fails (and thus whole
> update fails), restart is demanded too.  

commit 2b1c7ca27cb847fa218707182db33463a9a63152
Author: Richard Hughes <richard>
Date:   Tue Jul 28 11:47:51 2009 +0100

    Don't emit the RequireRestart security signals until the transaction completes with success. Fixes rh#513856
Comment 7 Steven M. Parrish 2009-09-13 00:25:01 UTC 
Richard is this fix in both 0.4.x and 0.5.x or just 0.5.x?

-- 
Steven M. Parrish - KDE Triage Master
                  - PackageKit Triager
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Comment 8 Richard Hughes 2009-09-13 08:28:43 UTC 
Just 0.5.x -- it included new strings, so cannot be backported.