Bug 513907
Summary: | fedora-security-guide-en-US goes boom in koji | ||
---|---|---|---|
Product: | [Community] Publican | Reporter: | eric |
Component: | publican | Assignee: | Jeff Fearn 🐞 <jfearn> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | urgent | Docs Contact: | |
Priority: | high | ||
Version: | 1.6 | CC: | docs, jfearn, kengert, mmcallis, petersen, publican-list |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-07-28 01:07:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
eric
2009-07-27 03:23:10 UTC
As I recall, and it has been a while, vendoropt was added during the review of publican as it is a required field. So removing it would seem to be the wrong thing. It looks to me like your package name is contains "Fedora Project" with a space, this is not a valid package name since spaces are not allowed in package names. Please attach the spec file so I can take a look at it. Hi Jeff, Yeah, it's getting the "Fedora Project" from the vendoropt. The package name is Fedora-Security-Guide. SPEC: http://cvs.fedoraproject.org/viewvc/rpms/fedora-security-guide-en-US/devel/fedora-security-guide-en-US.spec?revision=1.4&view=markup Thanks, Eric According to https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage the vendor tag should only be used for existing packaging that use it ... so you need to remove it from the spec file. I agree. That SPEC is how Publican generates it. So can it be removed? I wonder what changed since http://koji.fedoraproject.org/koji/taskinfo?taskID=1416027 ? Yeah, that's what I was wondering. Clearly the vendor tag has changed from 'fedora' to 'Fedora Project'. (In reply to comment #7) > I agree. That SPEC is how Publican generates it. So can it be removed? That vendor stuff was only added because it was a fedora packaging requirement. Since there are no existing books being shipped in Fedora, my solution would be to pull it out entirely from the next version. I agree. I don't see the need for it, here. Is this something in the fedora "brand" or ??? I'd be happy to pull it out of the code and provide a patch if you can point me in the direction of the proper file. (In reply to comment #14) > I agree. I don't see the need for it, here. > > Is this something in the fedora "brand" or ??? I'd be happy to pull it out of > the code and provide a patch if you can point me in the direction of the proper > file. It's in /usr/share/publican/xsl/dt_htmlsingle_spec.xsl You need to remove all references to vendor and vendoropt. Here is a diff: --- /usr/share/publican/xsl/dt_htmlsingle_spec.xsl 2009-03-27 12:12:05.000000000 +1000 +++ dt_htmlsingle_spec.xsl 2009-07-28 10:37:47.000000000 +1000 @@ -17,8 +17,6 @@ %if %{HTMLVIEW} %define viewer htmlview -%define vendor redhat- -%define vendoropt --vendor="redhat" %endif Name: <xsl:value-of select="$book-title"/>-<xsl:value-of select="$book-lang"/> @@ -66,7 +64,7 @@ Terminal=false EOF -desktop-file-install %{?vendoropt} --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{name}.desktop +desktop-file-install --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{name}.desktop %clean rm -rf $RPM_BUILD_ROOT @@ -74,7 +72,7 @@ %files %defattr(-,root,root,-) %doc tmp/<xsl:value-of select="$book-lang"/>/html-desktop/* -%{_datadir}/applications/%{?vendor}%{name}.desktop +%{_datadir}/applications/%{name}.desktop %changelog<xsl:value-of select="$log"/> This change is in place for the next release. Yeah, all is well here... Thanks! |