Bug 514061
| Summary: | yppasswd fails if passwords are SHA512 (or MD5/SHA256) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kumar Gala <galak> | ||||
| Component: | yp-tools | Assignee: | Karel Klíč <kklic> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 11 | CC: | rvokal, vcrhonek | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | yp-tools-2.9-7.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-05-20 18:42:14 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 407081 [details]
The patch fixing verifypassword()
This patch merges the -md5 and -sha-2 patches used in Fedora, and adds fixes verifypassword()
Built for rawhide: yp-tools-2_10-3_fc14 http://koji.fedoraproject.org/koji/buildinfo?buildID=167257 yp-tools-2.9-9.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/yp-tools-2.9-9.fc12 yp-tools-2.9-7.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/yp-tools-2.9-7.fc11 yp-tools-2.10-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/yp-tools-2.10-2.fc13 yp-tools-2.10-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yp-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/yp-tools-2.10-2.fc13 yp-tools-2.9-9.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yp-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/yp-tools-2.9-9.fc12 yp-tools-2.9-7.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update yp-tools'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/yp-tools-2.9-7.fc11 This message is a reminder that Fedora 11 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 11. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '11'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 11's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 11 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping yp-tools-2.10-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. yp-tools-2.9-9.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. yp-tools-2.9-7.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |
The code in yppasswd.c in: verifypassword (struct passwd *pwd, char *pwdstr, uid_t uid) assumes password are 13 chars, however with SHA512 or other hash the first 13 chars may not very enough to distinguish the new passwd from the old one: ... if (pwd->pw_passwd[0] && !strncmp (pwd->pw_passwd, crypt (pwdstr, pwd->pw_passwd), 13) && uid) ... The code needs to change to use the proper password length based on the hash scheme.