Bug 51446

Summary: Control center does not properly clean up.
Product: [Retired] Red Hat Public Beta Reporter: Owen Taylor <otaylor>
Component: control-centerAssignee: Jonathan Blandford <jrb>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: roswellCC: ddumas
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-08-10 15:48:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Owen Taylor 2001-08-10 15:44:34 UTC
In the "independent window' mode of operation of the control
center. (What you get if you launch capplets from the
menus or from "Start here"), we have 

 [ Apply ]  [ Close ]

Selecting close, or the window manager close decoration just
kills the capplet without properly cleaning up. The
capplet API only allows cleanups as OK - apply and close,
or cancel - revert back to when the dialog was 
opened and close.

Not cleaning up causes various bugs in various capplets. Many
capplets don't sync their final state until [ OK ] or [ Cancel ].


It's possible that it can be fixed up capplet by capplet, though
this would be a hard-to-catch API change, but if not, all
we can support is:

 [ Apply ]  [ OK ]

Where OK applies and closes. 

 [ OK  ] [ Cancel ]

Where Cancel Reverts back to the initial state,
not to the last Apply.

(A hack, would be to make Apply 'OK and restart capplet',
but I think that would look really horribly awful.

And the window mananger close decoration has to be either
OK or Cancel.

Both the theme selector and window manager capplets display
the wrong choice when they are reopened after switching
theme / or window manager because they never save their
final state.

Comment 1 Jonathan Blandford 2001-08-10 22:11:37 UTC
Changed to [ Apply] [  OK  ] [Cancel]