Bug 515040
| Summary: | Review Request: spamassassin-plugin-ixhash - iXhash fuzzy network hash plugin for spamassassin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-12 20:05:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Warren Togami
2009-08-01 03:49:07 UTC
I'll go ahead and review this. Look for a full review here in a bit. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 891a85984bb44b12431f5998a05fe2ff iXhash-1.5.5.tgz 891a85984bb44b12431f5998a05fe2ff iXhash-1.5.5.tgz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: spamassassin-plugin-ixhash.noarch: W: summary-not-capitalized iXhash fuzzy network hash plugin for spamassassin spamassassin-plugin-ixhash.src: W: summary-not-capitalized iXhash fuzzy network hash plugin for spamassassin Can be ignored, but iXhash doesn't mean much to most people I suspect. You could just drop that and cap the F in fuzzy? spamassassin-plugin-ixhash.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/spamassassin-plugin-ixhash-1.5.5/CHANGELOG spamassassin-plugin-ixhash.noarch: W: file-not-utf8 /usr/share/doc/spamassassin-plugin-ixhash-1.5.5/CHANGELOG Suggest: dos2unix them? Not a big deal, but easy to do. None of those are blockers, so this package is APPROVED. Please look at tweaking those on import. I didn't build this into Fedora yet because I am testing its safety. How can it be unsafe? Exposing the contents of messages to a 3rd party? It only sends the hash I thought... The possibility of false positives I'm canceling this for inclusion in Fedora for now. It slows down spamassassin substantially and doesn't classify mail well enough. |