Bug 515107
| Summary: | Review Request: perl-DBIx-Class-TimeStamp - DBIx::Class extension to update and create date and time based fields | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, jacek.radzikowski, jan.klepek, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/DBIx-Class-TimeStamp/ | ||
| Whiteboard: | |||
| Fixed In Version: | 0.12-1.fc10.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-15 08:14:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2009-08-02 05:09:21 UTC
*** Bug 515082 has been marked as a duplicate of this bug. *** fails during test in my mock for F11
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/02pod.t t/03podcoverage.t t/04basic.t t/05datetime.t t/06timestamp.t t/07date.t t/08noclobber.t
t/02pod.t .......... ok
t/03podcoverage.t .. ok
t/04basic.t ........ skipped: needs DBD::SQLite for testing
Bailout called. Further testing stopped: DBD::SQLite not installed
FAILED--Further testing stopped: DBD::SQLite not installed
RPM build errors:
make: *** [test_dynamic] Error 255
error: Bad exit status from /var/tmp/rpm-tmp.hzjbzo (%check)
Bad exit status from /var/tmp/rpm-tmp.hzjbzo (%check)
Child returncode was: 1
That looks to be a packaging error in perl-DBIx-Class-0.08012 in F11. The 0.08108 version in rawhide (and in F11 updates-testing) properly requires perl(DBD::SQLite). Until the updated version makes its way to stable, either mock build for rawhide, or enable the testing repository for F11 to get a working build. And yet another cookie-cutter review. As I always build in rawhide I don't see the above failure. The only interesting thing here is the huge dependency list sucked in by graphviz. That package could really use a split.
* source files match upstream. sha256sum:
4a1fa7c96d655073bc48f893980a8290414ecdd69c91d792136e3a389eff3033
DBIx-Class-TimeStamp-0.12.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
perl(DBIx::Class::TimeStamp) = 0.12
perl-DBIx-Class-TimeStamp = 0.12-1.fc12
=
perl(:MODULE_COMPAT_5.10.0)
perl(DBIx::Class)
perl(DBIx::Class::DynamicDefault)
perl(DateTime)
perl(base)
perl(strict)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=7, Tests=22, 4 wallclock secs
( 0.03 usr 0.02 sys + 1.47 cusr 0.18 csys = 1.70 CPU)
Result: PASS
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
New Package CVS Request ======================= Package Name: perl-DBIx-Class-TimeStamp Short Description: DBIx::Class extension to update and create date and time based fields Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig CVS done. perl-DBIx-Class-TimeStamp-0.12-1.fc11.1 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-DBIx-Class-TimeStamp-0.12-1.fc11.1 perl-DBIx-Class-TimeStamp-0.12-1.fc10.1 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-DBIx-Class-TimeStamp-0.12-1.fc10.1 perl-DBIx-Class-TimeStamp-0.12-1.fc11.1 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-DBIx-Class-TimeStamp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8375 perl-DBIx-Class-TimeStamp-0.12-1.fc10.1 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-DBIx-Class-TimeStamp'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8381 perl-DBIx-Class-TimeStamp-0.12-1.fc11.1 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-DBIx-Class-TimeStamp-0.12-1.fc10.1 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |