Bug 515144
| Summary: | Review Request: vifir - A viewer for electronic aviation charts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.4-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-15 08:09:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-08-02 17:23:49 UTC
I'll review it REVIEW:
+ rpmlint is silent
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as provided in the spec URL.
[petro@Sulaco SOURCES]$ sha256sum vifir-0.4.tar.gz*
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 vifir-0.4.tar.gz
340db9360c8f3710192fd8b773736e11c992cd3dad855ba848887a15f7d06607 vifir-0.4.tar.gz.1
[petro@Sulaco SOURCES]$
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See link above.
+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code or permissible content.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
+ The packages includes a %{name}.desktop file, and that file is properly installed with desktop-file-install in the %install section.
+ The package does not own files or directories already owned by other packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8
Don't forget to add it to the list of GIS-related applications on the dedicated wiki-page.
APPROVED.
Thanks Peter for the review. New Package CVS Request ======================= Package Name: vifir Short Description: A viewer for electronic aviation charts units Owners: fab Branches: F-10 F-11 InitialCC: CVS done. vifir-0.4-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/vifir-0.4-1.fc11 vifir-0.4-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/vifir-0.4-1.fc10 vifir-0.4-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vifir'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8277 vifir-0.4-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vifir'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8287 vifir-0.4-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. vifir-0.4-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. |