Bug 515308
| Summary: | Review Request: usbmuxd - Daemon for communicating with Apple's iPod Touch and iPhone | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Bastien Nocera <bnocera> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | bnocera, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | bnocera:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-13 12:42:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Robinson
2009-08-03 16:44:00 UTC
The udev rules don't work. I sent patches for them on the mailing-list. New upstream release with new udev patches http://pbrobinson.fedorapeople.org/usbmuxd-0.1.2-1.fc11.src.rpm X source files doesn't match upstream. sha256sum: ada66b3f8dd297c8b3e97666240672194e46b409f7ecd4676bdd75fe67ae431f usbmuxd-0.1.2.tar.gz 2d7092588dcb69b3f96133fc8a39c9668a82e54c4ea4c4de9e9a061802fd972e usbmuxd-0.1.2.tar.gz should be fixed by using 0.1.3 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field does not match the actual license. Some files are missing any license information, src/usbmux.h is under the LGPL, would be better if upstream added a COPYING.LIB as well and a mention of which licenses which parts of the code have (LGPL for libs, and GPL for the daemon I would guess) * license is open source-compatible. X latest version is being packaged. Need to package 0.1.3, best wait until udev startup problems are solved. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in koji. * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane. * %check is not present; included test suite can't be run at build time. * shared libraries installed: ldconfig is called properly. unversioned .so link is in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * scriptlets are OK (ldconfig). * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * pkgconfig files are in the -devel package, with pkgconfig dependency. * no static libraries. * no libtool .la files. Please fix the license problems, udev integration, and package up the latest version before committing. > Please fix the license problems, udev integration, and package up the latest > version before committing. License updated to "GPLv2+ and LGPLv2+" and updated to the current 0.1.3 version. udev should be fixed in 0.1.4 and I'll update the package again once that is released. SRPM: http://pbrobinson.fedorapeople.org/usbmuxd-0.1.3-1.fc11.src.rpm And Christophe also found:
%{_sbindir}/usbmuxd
should be in the main package, not -devel
(In reply to comment #5) > And Christophe also found: > %{_sbindir}/usbmuxd > should be in the main package, not -devel I thought I'd already fixed that. I certainly noticed it. I've fixed it now in my local package and will update the package once the next release is out. Package updated to new upstream release that contains the udev patches. SPEC: http://pbrobinson.fedorapeople.org/usbmuxd.spec SRPM: http://pbrobinson.fedorapeople.org/usbmuxd-0.1.4-1.fc11.src.rpm Looks fine. Note how the fedora-review is already plussed, so go on, and import it :) Hehe, missed that one :) New Package CVS Request ======================= Package Name: usbmuxd Short Description: Daemon for communicating with Apple's iPod Touch and iPhone Owners: pbrobinson Branches: F-11 F-10 InitialCC: cvs done. built in koji for rawhide. And now in rawhide |