Bug 515555
| Summary: | F-12-Alpha-TC - mkofboot doesn't return the proper exit code | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James Laska <jlaska> | ||||||||||||||
| Component: | yaboot | Assignee: | David Woodhouse <dwmw2> | ||||||||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||
| Severity: | high | Docs Contact: | |||||||||||||||
| Priority: | low | ||||||||||||||||
| Version: | rawhide | CC: | dcantrell, dwmw2, jturner, notting, pnasrat, rrakus, tony, vanmeeuwen+fedora | ||||||||||||||
| Target Milestone: | --- | Keywords: | Reopened | ||||||||||||||
| Target Release: | --- | ||||||||||||||||
| Hardware: | ppc64 | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||
| Last Closed: | 2009-08-11 19:27:57 UTC | Type: | --- | ||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||
| Embargoed: | |||||||||||||||||
| Bug Depends On: | |||||||||||||||||
| Bug Blocks: | 507676 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
James Laska
2009-08-04 18:13:47 UTC
Created attachment 356220 [details]
bash -x mkofboot -f -C /boot/etc/yaboot.conf
Created attachment 356221 [details]
program.log
Created attachment 356222 [details]
storage.log
Created attachment 356223 [details]
syslog
Adding for review during Fedora Alpha blocker bug meeting. This defect appears to block all installations of F-12-Alpha on ppc64. Further investigation with Chris Lumens highlights that the mkofboot command is not returning a proper exit code. The command returns '1' (fail) when called with the default expected arguments. The command returns '0' (pass) when running with a -v|--verbose parameter. This is similar to the ybin issue discovered by koan (see https://bugzilla.redhat.com/show_bug.cgi?id=508969#c5). Reassigning to yaboot. sh-4.0# chroot /mnt/sysimage /bin/sh sh-4.0# /sbin/mkofboot -v -f -C /boot/etc/yaboot.conf mkofboot: Installing primary bootstrap /usr/lib/yaboot/yaboot onto /dev/sda1... mkofboot: Installation successful mkofboot: Installation complete. sh-4.0# echo $? 0 sh-4.0# /sbin/mkofboot -f -C /boot/etc/yaboot.conf sh-4.0# echo $? 1 sh-4.0# /sbin/mkofboot -v -f -C /boot/etc/yaboot.conf mkofboot: Installing primary bootstrap /usr/lib/yaboot/yaboot onto /dev/sda1... mkofboot: Installation successful mkofboot: Installation complete. sh-4.0# echo $? 0 Created attachment 356605 [details]
Test patch to fix the return value of raw_install() in mkofboot
Please test this patch.
This definitely seems to be a ppc64 only thing. a ppc32 install on a macmini works just fine. Testing the suggested patch yields the expected result: # /sbin/mkofboot -f -C /boot/etc/yaboot.conf ; echo $? 0 # /sbin/mkofboot -v -f -C /boot/etc/yaboot.conf ; echo $? mkofboot: Installing primary bootstrap /usr/lib/yaboot/yaboot onto /dev/sda1... mkofboot: Installation successful mkofboot: Installation complete. 0 Fixed in yaboot-1.3.14-15.fc12 re-opening until it is actually tagged for the Alpha. Did this patch apply correctly? I'm not seeing the change in the new package when I install it on my ppc64 system, or inspect it manually with rpm2cpio? Did this not apply correctly during build? # rpm -q yaboot yaboot-1.3.14-15.fc12.ppc # /sbin/mkofboot -f -C /boot/etc/yaboot.conf ; echo $? 1 Updated ... According to notting, /sbin/mkofboot is a symlink to /sbin/ybin which caused the patch to not apply during build. Tested a scratch build from notting and confirmed the fix (see http://koji.fedoraproject.org/koji/taskinfo?taskID=1589941). Fixed in -16.fc12. VERIFIED in rawhide-20090811 sh-4.0# grep anaconda.version /tmp/anaconda.log 18:54:18 INFO : anaconda version 12.13 on ppc starting sh-4.0# rpm -q yaboot yaboot-1.3.14-16.fc12.ppc |