Bug 516578

Summary: Review Request: hyphen-fo - Faroese hyphenation rules
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-13 08:12:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Caolan McNamara 2009-08-10 14:29:36 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-fo.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-fo-0.20040420-1.fc11.src.rpm
Description: Faroese hyphenation rules

Comment 1 Parag AN(पराग) 2009-08-11 10:20:47 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1597506
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
85ad57dbee618da1b988a57a38ad4ca24da076df  hyph_fo_FO-20040420a.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 2 Caolan McNamara 2009-08-11 13:27:07 UTC
New Package CVS Request
=======================
Package Name: hyphen-fo
Short Description: Faroese hyphenation rules
Owners: caolanm
Branches: devel
InitialCC:

Comment 3 Kevin Fenzi 2009-08-13 00:03:18 UTC
cvs done.