Bug 517021
| Summary: | Review Request: perl-DBIx-Simple - Easy-to-use OO interface to DBI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | caius.chance, fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-24 07:03:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marcela Mašláňová
2009-08-12 12:12:26 UTC
$ rpmlint perl-DBIx-Simple.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. mock done successfully: INFO: Done(perl-DBIx-Simple-1.32-1.fc11.src.rpm) Config(fedora-rawhide-i386) 1 minutes 28 seconds So what now? I set fedora-review flag to ? Should I fix something else? Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1619858 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 124663099e555e4449844450dc5cbe5f3a291a3f DBIx-Simple-1.32.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=6, 0 wallclock secs ( 0.06 usr 0.01 sys + 0.22 cusr 0.04 csys = 0.33 CPU) + Package perl-DBIx-Simple-1.32-1.fc12.noarch => Provides: perl(DBIx::Simple) perl(DBIx::Simple::DeadObject) perl(DBIx::Simple::Dummy) perl(DBIx::Simple::Result) perl(DBIx::Simple::Statement) Requires: perl >= 0:5.006 perl(Carp) perl(DBI) perl(strict) + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-DBIx-Simple Short Description: Easy-to-use OO interface to DBI Owners: mmaslano InitialCC: perl-sig CVS Done without branches you get devel only Yes, I know. I wanted only devel branch. Thank you. |