Bug 517409
| Summary: | Review Request: django-authority - A Django app for generic per-object permissions and custom permission checks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Diego Búrigo Zacarão <diegobz> |
| Component: | Package Review | Assignee: | Allisson Azevedo <allisson> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | allisson, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | allisson:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-18 21:14:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Diego Búrigo Zacarão
2009-08-13 19:19:02 UTC
I'll make review soon as posible :) Well, BAD: * rpmlint issues: django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._handling_admin.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._tips_tricks.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._installation.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._configuration.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._support.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._index.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._handling_template.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._create_per_object_permission.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.theme/nature/._theme.conf django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.static django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.static django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._check_python.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/build/html/.buildinfo django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._documentation_guidelines.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.theme django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.theme django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._check_templates.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._create_basic_permission.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._handling_python.txt django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/._check_decorator.txt 1 packages and 0 specfiles checked; 0 errors, 20 warnings. Please fix this issues :) Ops! Spec URL: http://diegobz.fedorapeople.org/packages/django-authority/django-authority.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-authority/django-authority-0.3-2.fc11.src.rpm BAD: * rpmlint: django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.static django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.static django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/build/html/.buildinfo django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.theme django-authority.noarch: W: hidden-file-or-dir /usr/share/doc/django-authority-0.3/docs/.theme 1 packages and 0 specfiles checked; 0 errors, 5 warnings. I suggest remove docs/ for %doc section, these docs are build with python-sphinx, but, using command for build (python setup.py build_sphinx) fails on my F-11. * %doc section: Please add AUTHORS, LICENSE and README in %doc section. I added in %doc the docs/build/html instead. Spec URL: http://diegobz.fedorapeople.org/packages/django-authority/django-authority.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-authority/django-authority-0.3-2.fc11.src.rpm %changelog * Fri Aug 14 2009 Diego Búrigo Zacarão <diegobz> 0.3-2 (...) - Added only HTML built doc files from docs dir - Added some missed doc files like AUTHORS - Clean up .builinfo files It's good for me :) APPROVED Thank you, Allisson. New Package CVS Request ======================= Package Name: django-authority Short Description: A Django app for generic per-object permissions and custom permission checks Owners: diegobz Branches: F-10 F-11 EL-5 InitialCC: diegobz cvs done. django-authority-0.3-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/django-authority-0.3-2.el5 django-authority-0.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/django-authority-0.3-2.fc11 django-authority-0.3-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-authority'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0290 django-authority-0.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. django-authority-0.3-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |