Bug 517412
| Summary: | Review Request: django-profile - Django pluggable user profile zone | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Diego Búrigo Zacarão <diegobz> |
| Component: | Package Review | Assignee: | Allisson Azevedo <allisson> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | allisson, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | allisson:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.6-0.2.20090813svnr420.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-18 21:16:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Diego Búrigo Zacarão
2009-08-13 19:23:13 UTC
I'll make review soon as posible :) Well, BAD: * rpmlint issues: django-profile.noarch: W: incoherent-version-in-changelog 0.6-0.1.20090813svn420 ['0.6-0.1.20090813svnr420.fc11', '0.6-0.1.20090813svnr420'] django-profile.noarch: W: no-documentation django-profile.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/demo/manage.py 0644 /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Please fix this issues. * no %doc files: Please add CHANGELOG.txt, LICENSE.txt, README.txt and TODO.txt in %doc section. * License mismatch: setup.py informs a MIT license, but, LICENSE.txt is a BSD license template, see those templates: http://www.opensource.org/licenses/mit-license.php http://www.opensource.org/licenses/bsd-license.php Spec URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile-0.6-0.2.20090813svnr420.fc11.src.rpm * Fri Aug 14 2009 Diego Búrigo Zacarão <diegobz> 0.6-0.2.20090813svnr420 - Added docs - Fixed version in the previous changelog - Fixed License to BSD based on the LICENSE.txt file Is it enough to change the license to BSD? I've opened a ticket upstream though. http://code.google.com/p/django-profile/issues/detail?id=64 BAD: * rpmlint django-profile.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/demo/manage.py 0644 /usr/bin/env 1 packages and 0 specfiles checked; 1 errors, 0 warnings. I think this demo program at (/usr/lib/python2.6/site-packages/demo/) should be moved to docs. Updated! Spec URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile-0.6-0.2.20090813svnr420.fc11.src.rpm * Fri Aug 14 2009 Diego Búrigo Zacarão <diegobz> 0.6-0.2.20090813svnr420 (...) - Moved demo app to docs Well,
You added demo/ in %doc but still here in /usr/lib/python2.6/site-packages/demo/ :)
Modify %files section and add a %exclude like this:
%files
%defattr(-,root,root,-)
%doc INSTALL.txt CHANGELOG.txt LICENSE.txt README.txt TODO.txt demo/
%{python_sitelib}/*
%exclude %{python_sitelib}/demo
Ops... didn't know about it. :) Spec URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile.spec SRPM URL: http://diegobz.fedorapeople.org/packages/django-profile/django-profile-0.6-0.2.20090813svnr420.fc11.src.rpm %changelog * Fri Aug 14 2009 Diego Búrigo Zacarão <diegobz> 0.6-0.2.20090813svnr420 (...) - Excluded demo app from python path It's ok now :) APPROVED Thank you, Allisson. New Package CVS Request ======================= Package Name: django-profile Short Description: Django pluggable user profile zone Owners: diegobz Branches: F-10 F-11 EL-5 InitialCC: diegobz cvs done. django-profile-0.6-0.2.20090813svnr420.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/django-profile-0.6-0.2.20090813svnr420.fc11 django-profile-0.6-0.2.20090813svnr420.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/django-profile-0.6-0.2.20090813svnr420.el5 django-profile-0.6-0.2.20090813svnr420.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-profile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0293 django-profile-0.6-0.2.20090813svnr420.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. django-profile-0.6-0.2.20090813svnr420.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |