Bug 517511

Summary: Package Review: perl-Parse-ExuberantCTags - Efficiently parse exuberant ctags files
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-08-18 05:53:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2009-08-14 12:54:07 UTC
Spec URL: http://mmaslano.fedorapeople.org/review/perl-Parse-ExuberantCTags.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Parse-ExuberantCTags-1.01-1.fc11.src.rpm
Description: This Perl module parses ctags files and handles both traditional ctags as well as extended ctags files such as produced with Exuberant ctags. To the best of my knowledge, it does not handle emacs-style "etags" files.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1605052

Comment 1 Parag AN(पराग) 2009-08-14 13:30:11 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1605052
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream url
79bd974d151cc6923b38cece4f563bc09cb9eb19  Parse-ExuberantCTags-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=21,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.04 cusr  0.00
csys =  0.07 CPU)
+ Package perl-Parse-ExuberantCTags-1.01-1.fc12.i686=>
Provides: ExuberantCTags.so perl(Parse::ExuberantCTags) = 1.01
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.4) perl >= 0:5.006001 perl(XSLoader) perl(strict)
perl(warnings) rtld(GNU_HASH)

APPROVED.

Comment 2 Marcela Mašláňová 2009-08-17 06:45:00 UTC
New Package CVS Request
=======================
Package Name: perl-Parse-ExuberantCTags
Short Description: Efficiently parse exuberant ctags files
Owners: mmaslano
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-08-17 18:30:10 UTC
cvs done.