|Summary:||RFE: SCTP support missing from SELinux|
|Product:||[Fedora] Fedora||Reporter:||Henrik Nordström <henrik>|
|Component:||kernel||Assignee:||Paul Moore <pmoore>|
|Status:||CLOSED CURRENTRELEASE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Version:||rawhide||CC:||dwalsh, itamar, jburke, jkortus, jose.p.oliveira.oss, jrieden, kernel-maint, mgrepl, nhorman, osabart, paul.moore, pmoore, rkhan, sds|
|Fixed In Version:||Doc Type:||Enhancement|
|Doc Text:||Story Points:||---|
|Last Closed:||2018-09-14 01:25:06 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
|Bug Depends On:|
|Bug Blocks:||517000, 715517, 715518, 715519|
Description Henrik Nordström 2009-08-15 23:15:28 UTC
Description of problem: SELinux handles non-TCP/UDP network protocols such as SCTP very poorly Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. make one-one-server LDFLAGS=-lsctp 2. ./one-one-server 8888 3. ./one-one-client 127.0.0.1 8888 Actual results: one-one-server is denied to bind. if that's solved then reading/writing from the socket is denied as well. Expected results: Should work. Additional info: Not sure what to file this bug on.. Support for SCTP is missing completely in SELinux, not just the from the policy. The kernel maps everything "unknown" as if it was rawip, which allows to workaround the problem but not sure if this is entirely safe as rawip is a bit more than just SCTP... For rawip there is no rule governing name_bind, and as result only the dynamic port range is allowed (>32768). Ideally the kernel should know about SCTP and perhaps other port based protocols and map these as suitable to the policy. TCP/IP port numbers are assigned pretty much protocol neutral over tcp/udp/sctp, and unless one has specific reason to do different port policy should generally apply equal to allow protocol support to evolve without having to update policy each time as such updates is too easily forgotten.
Comment 1 Henrik Nordström 2009-08-15 23:16:45 UTC
Created attachment 357552 [details] one-one-server.c Example SCTP server appliation
Comment 2 Henrik Nordström 2009-08-15 23:17:24 UTC
Created attachment 357553 [details] one-one-client.c Example STCP client application
Comment 3 Henrik Nordström 2009-08-15 23:21:03 UTC
Created attachment 357554 [details] rawip selinux policy stub A dummy selinux policy stub module usable as workaround enabling the test appliations to run by relaxing rawip considerably. Not meant as a solution without further analysis of the use of rawip.
Comment 4 Stephen Smalley 2009-08-18 14:40:07 UTC
See: http://marc.info/?l=selinux&m=124342862804578&w=2 for a summary of what would need to be done to properly support SCTP.
Comment 5 Stephen Smalley 2009-08-18 14:42:10 UTC
The policy stub in comment #3 has an unlabeled_t socket, which shouldn't happen (not even for SCTP). That would be a bug in the kernel. More details would be helpful, including the original raw audit log entries.
Comment 6 Henrik Nordström 2009-08-18 18:41:04 UTC
Created attachment 357841 [details] strace of one-one-server
Comment 7 Henrik Nordström 2009-08-18 18:41:50 UTC
Created attachment 357842 [details] audit.log with setenforce 0 and without the policy stub
Comment 8 Stephen Smalley 2009-08-19 11:44:55 UTC
Ok, so lack of security hooks within the sctp code means that new server sockets returned by accept() are left in the unlabeled state. Not good. This is a kernel bug that should be fixed regardless of whether we do the steps outlined in comment #4, although they could be done together.
Comment 9 Paul Moore 2009-08-19 19:20:04 UTC
(In reply to comment #8) > Ok, so lack of security hooks within the sctp code means that new server > sockets returned by accept() are left in the unlabeled state. Not good. > This is a kernel bug that should be fixed regardless ... I just started looking at this today and talking with the SCTP maintainer about it - it will probably be a few days before I can propose a solution. However, if anyone has any bright ideas I'd love to hear them.
Comment 10 Henrik Nordström 2009-10-29 01:10:42 UTC
Any progress on this?
Comment 11 Paul Moore 2009-10-29 21:10:58 UTC
Nothing substantial at this point. Problems involve limited time to devote to this and my own limited understanding of SCTP. The first hurdle is trying to understand how SCTP operates and if a socket returned by accept() can be labeled the same way as TCP and UDP. The next step is to figuring out what the SCTP analogue is for an incoming connection request (this is where we do the bulk of the child socket labeling); I suspect this is a SCTP "association" but I haven't looked into it enough yet. Henrik (or anyone else for that matter), do you have a pointer to document with provides a brief overview of how SCTP works? I'm thinking about detail along the lines of an "executive summary" and not RFC level detail. Also, as usual, I'm happy to review patches ;)
Comment 12 Henrik Nordström 2009-10-29 22:29:32 UTC
SCTP "connections" are associations, and sets up a relation between two nodes SCTP is different and similar to both TCP and UDP depending on how it's used. My comment there is that standard port number assignments is generally the same for all three protocols. I.e. port 80 is assigned for both TCP (common), UDP (uncommon) and SCTP (not yet in use, but hopefully...) so from a policy perspective it may be beneficial to merge the three in many cases, but not neccesarily from SELinux implementation. A quick google turned up the following primer which seems to be the level you ask for http://datatag.web.cern.ch/datatag/WP3/sctp/primer.htm what is missing from there is the sockets api which has some additional twists. This is quite well documented in the SCTP(7) man page however. But to connect the two: - SCTP sockets come in one-to-one and one-to-many flavors. one-to-one has explicit association setup like TCP, while one-to-many is more like unconnected UDP. In the one-to-many case assications are automatically created and closed by the kernel as needed by the traffic flow and is a major difference from UDP which is connectionless.
Comment 13 Neil Horman 2009-10-29 22:59:09 UTC
Paul, you can get a quick overview here as well: http://lksctp.sourceforge.net/overview.html I'll be happy to answer any questions you have on sctp as well.
Comment 14 Bug Zapper 2010-04-28 09:47:13 UTC
This message is a reminder that Fedora 11 is nearing its end of life. Approximately 30 (thirty) days from now Fedora will stop maintaining and issuing updates for Fedora 11. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '11'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 11's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 11 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora please change the 'version' of this bug to the applicable version. If you are unable to change the version, please add a comment here and someone will do it for you. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Comment 15 Bug Zapper 2010-07-30 10:42:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle. Changing version to '14'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping
Comment 16 Daniel Walsh 2011-02-16 21:59:46 UTC
*** Bug 677622 has been marked as a duplicate of this bug. ***
Comment 17 Henrik Nordström 2011-06-23 08:10:46 UTC
Some links to prior discussions on what is needed to implement support http://marc.info/?l=selinux&m=124342862804578&w=2 http://marc.info/?l=selinux&m=120889478612107&w=2 And apparently first reported for F4. http://marc.info/?l=fedora-selinux-list&m=112805478805484&w=2
Comment 21 Paul Moore 2018-09-14 01:25:06 UTC
Proper SCTP support landed in Linux v4.17.