Bug 517851

Taking this.

Satya: I'm wondering if you did any informal package reviews. In case you didn't it might be a good idea to do a couple of them, so that you can demonstrate that you're familiar with packaging guidelines in order to get sponsored.

Satya: as your GSoC mentor, if you do some reviews informally, and can get sponsored as a packager before the program is over, i can definitely take that into account as part of your evaluation. Let me know if you have any questions about this process.

Did a review at:

https://bugzilla.redhat.com/show_bug.cgi?id=480724#c38

Did another review at:

https://bugzilla.redhat.com/show_bug.cgi?id=455622

1.) Requires list

Please consider using "webserver" dependency (and owning /etc/httpd then) instead of "httpd", at least some of the web application packages do that

2.) Configuration file

Please mark this file as %config(noreplace):
/usr/share/beacon/php/settings.php

3.) Do not abuse /var/tmp

Please refer to FHS for reason why is this bad. I suggest you use /var/lib/beacon instead.

Thanks a lot for reviewing the package.

Updated the spec file with the changes suggested.

New spec file: http://rakesh.fedorapeople.org/spec/beacon.spec
New SRPM: http://rakesh.fedorapeople.org/srpm/beacon-0.5-2.fc11.src.rpm

I updated the spec file to require webserver instead of httpd but I am unsure if I should own /etc/httpd. Could you please explain this a bit as I seem to be missing something here.

The beacon upstream shifted to using MySQL (they used flat files before because of which I needed /var/tmp) so I could simply remove that and update the tarball.

I also added settings.php to %config(noreplace)

(In reply to comment #6)
> Updated the spec file with the changes suggested.

Thanks!

> I updated the spec file to require webserver instead of httpd but I am unsure
> if I should own /etc/httpd. Could you please explain this a bit as I seem to be
> missing something here.

If you create a directory that neither you nor none of your dependencies own, that directory would not be removed upon package removal. That could happen in case user would elect to use e.g. lighttpd instead of apache httpd (which would satisfy the webserver dependency).

So you can either depend on "webserver" and own /etc/httpd, or depend directly on "httpd" (as you did previously). It might be a better idea to just switch back to httpd (since you use apache:apache user, etc.); sorry for the noise.

Also, please improve your %description, it seems rather short and uninformative.

I don't think any of these are blockers, I'll approve the package once you are sponsored. Please apply for packagers group so that you can get sponsored.

Thanks a lot!

New Description: Beacon is an XSLT based plug-able WYSIWYG editor for DocBook xml. It is intended to serve as an easy to use tool which will attract new contributors who would otherwise be discouraged by the steep learning curve involved with DocBook and will also provide a convenient alternative to those who are old-timers. More information is available at https://fedoraproject.org/wiki/DocBook_Editor_Documentation and https://fedoraproject.org/wiki/DocBook_Editor_Feature.

New spec file: http://rakesh.fedorapeople.org/spec/beacon.spec
New SRPM: http://rakesh.fedorapeople.org/srpm/beacon-0.5-3.fc11.src.rpm

I just applied to join the packagers group. My FAS username is satyak.

Seems fine now. Accepted you into packager group, lifting FE-NEEDSPONSOR.

The package is APPROVED

Thanks :)

New Package CVS Request
=======================

Package Name: beacon
Short Description: WYSIWYG editor for docbook xml
Branches: F-10 F-11
InitialCC:

Oops!

New Package CVS Request
=======================

Package Name: beacon
Short Description: WYSIWYG editor for docbook xml
Owners: satyak
Branches: F-10 F-11
InitialCC:

The package database has an issue with your account: 

Email address satya.komaragiri is not a valid bugzilla email address.  Either make a bugzilla account with that email address or change your email address in the Fedora Account System https://admin.fedoraproject.org/accounts/ to a valid bugzilla email address and try again.

Please set the fedora-cvs flag back to '?' when you've fixed the above issue.

I have made a bugzilla account with satya.komaragiri.
Changing the fedora-cvs flag to ?

CVS done.

beacon-0.5-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/beacon-0.5-3.fc11

beacon-0.5-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/beacon-0.5-3.fc10

beacon-0.5-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

beacon-0.5-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.