Bug 517858

It seems that you are not in the packager group.  Have you read through http://fedoraproject.org/wiki/Join_the_package_collection_maintainers?  If not, you really should, and if so then you missed the bit about telling folks that you need a sponsor.

Sorry, I forgot to state that I need a sponsor.

CC

koji build --scratch dist-f11 ../SRPMS/RackTables-0.17.4-1.fc11.src.rpm 
Uploading srpm: ../SRPMS/RackTables-0.17.4-1.fc11.src.rpm
[====================================] 100% 00:00:09 382.60 KiB  39.93 KiB/sec
Created task: 1619497
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1619497
Watching tasks (this may be safely interrupted)...
1619497 build (dist-f11, RackTables-0.17.4-1.fc11.src.rpm): free
1619497 build (dist-f11, RackTables-0.17.4-1.fc11.src.rpm): free -> open (x86-6.fedora.phx.redhat.com)
  1619498 buildArch (RackTables-0.17.4-1.fc11.src.rpm, noarch): open (x86-4.fedora.phx.redhat.com)
  1619498 buildArch (RackTables-0.17.4-1.fc11.src.rpm, noarch): open (x86-4.fedora.phx.redhat.com) -> closed
  0 free  1 open  1 done  0 failed
1619497 build (dist-f11, RackTables-0.17.4-1.fc11.src.rpm): open (x86-6.fedora.phx.redhat.com) -> closed
  0 free  0 open  2 done  0 failed

1619497 build (dist-f11, RackTables-0.17.4-1.fc11.src.rpm) completed successfully

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-3.src.rpm

- Tidied spec file 
- Fixed the associated Apache config file which was syntactically incorrect
- Added 'quickstart.sh' script to make installing RackTables easier for new users

CC

Well, I don't know how to use this package, however:

* Summary
---------------------------------------------------------
RackTables.noarch: W: name-repeated-in-summary RackTables
---------------------------------------------------------
  - On Fedora now we think that repeating the package's name in
    Summary is just redundant.

* License
  - All scripts are under GPLv2 and its compat licenses. However
    this package also includes some "contents" and are under
    CC-BY-SA.
    I think showing contents' license is preferable, so I recommend
    to "GPLv2 and CC-BY-SA" as license tag.

* About /usr/share/RackTables/inc/secret.php:
----------------------------------------------------------
RackTables.noarch: E: file-in-usr-marked-as-conffile /usr/share/RackTables/inc/secret.php
RackTables.noarch: E: non-readable /usr/share/RackTables/inc/secret.php 0660
RackTables.noarch: E: zero-length /usr/share/RackTables/inc/secret.php
----------------------------------------------------------
  - The latter 2 rpmlint errors (non-readable and zero-length) are perhaps
    by intention, however just to be clear would you explain if these
    are as you expect?

  - The first one rpmlint error should be fixed. All configuration files
    should be under %{_sysconfdir}.
    If this file needs to be under %{_datadir}/%{name}/inc, you should
    * Create %{_sysconfdir}/%{name} directory
    * Put secret.php under %{_sysconfdir}/%{name}
    * And create a symlink of %{_datadir}/%{name}/inc/secret.php which
      points to %{_sysconfdir}/%{name}/secret.php.

* spec file cleanup
-----------------------------------------------------------
mkdir -p $RPM_BUILD_ROOT%{_docdir}
-----------------------------------------------------------
  - What is this line for?
  ! Note
    "%doc COPYING" entry in %files
    - first removes %buildroot%_defaultdocdir/%{name}-%{version}
    - then creates %buildroot%_defaultdocdir/%{name}-%{version}
    - and installs files specified by %doc to 
      %buildroot%_defaultdocdir/%{name}-%{version}

* %files
  - build.log says:
-----------------------------------------------------------
    80  warning: File listed twice: /usr/share/RackTables/inc/secret.php
-----------------------------------------------------------
    In the spec file, this file is actually listed as twice:
-----------------------------------------------------------
%files
%attr(660,root,apache) %config(noreplace) %{_datadir}/%{name}/inc/secret.php
%{_datadir}/%{name}/*
-----------------------------------------------------------
    Please fix this so that this file is listed only once in the
    spec file.

Hi and thank you for another detailed, constructive review.

- Removed redundant 'RackTables' from the summary and description.
- Changed license as suggested.
- Put secret.php into /etc/RackTables (I've found that it doesn't have to be empty) and created symlink back to %{_datadir}/%{name}/inc.
- Removed 'mkdir -p $RPM_BUILD_ROOT%{_docdir}'
- Stopped listing inc/secret.php twice.

[build@rpm02 ~]$ rpmlint /var/lib/mock/hp-rhel-5-x86_64/root/builddir/build/SPECS/RackTables.spec /var/lib/mock/hp-rhel-5-x86_64/result/*rpm
RackTables.noarch: W: dangling-relative-symlink /usr/share/RackTables/inc/secret.php ../../etc/RackTables/secret.php
RackTables.noarch: W: incoherent-version-in-changelog 0.17.4-4 0.17.4-4.el5
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[build@rpm02 ~]$

Not sure how to address the 'dangling symlink' warning.

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-4.src.rpm

Thanks again

CC

(In reply to comment #6)
> SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-4.src.rpm
Seems 404...

By the way, while currently I cannot see your newest spec:
> RackTables.noarch: W: dangling-relative-symlink /usr/share/RackTables/inc/secret.php ../../etc/RackTables/secret.php

note that the directory name of "/usr/share/RackTables/inc/secret.php"
is "/usr/share/RackTables/inc" and the relative path to 
"/etc/RackTables/secret.php" from there is
"../../../../etc/RackTables/secret.php".

Oops, sorry.  They're there now.

CC

Fixed dangling symlink.  Not sure how I missed that, it was pretty obvious really.

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-5.src.rpm

Could I also trouble you to review BZ#489424?  It's been assigned but there's not been much action.

Thanks

CC

For -5:

? Duplicate files
  - I noticed that 4 document files "COPYING LICENSE ChangeLog README"
    are installed under both /usr/share/RackTables and 
    /usr/share/doc/RackTables-0.17.4 .

    Would you check if 4 document files under /usr/share/RackTables
    are needed? (If needed, you don't have to remove these files).

* About %{_sysconfdir}/%{name}/secret.php
  - The directory %{_sysconfdir}/%{name} is not owned by any packages,
    which must be owned by this package.

  - Is the permission/owner/group of this files okay with
    the current setting (i.e. 0644 permission with (root,root))?

! Note
----------------------------------------------------------
%files
%dir %{_datadir}/%{name}
%{_datadir}/%{name}/*
----------------------------------------------------------
  can be simplified with
----------------------------------------------------------
%files
%{_datadir}/%{name}/
----------------------------------------------------------
  The latter form contains the directory %_datadir/%name and all
  files/directories/etc under %_datadir/%name.

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-6.src.rpm

- Own /etc/RackTables/
- Fix duplicate files
- Set ownership/mode of /etc/RackTables/secret.php correctly
- Fix contrib/quickinstall.sh to write a valid /etc/RackTables/secret.php

[coec@rsim SPECS]$ rpmlint /home/coec/rpmbuild/SRPMS/RackTables-0.17.4-6.fc11.src.rpm /home/coec/rpmbuild/RPMS/noarch/RackTables-0.17.4-6.fc11.noarch.rpm RackTables.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[coec@rsim SPECS]$

For -6:

* %_docdir
  - Again I see this line:
-----------------------------------------------------------
    35  mkdir -p $RPM_BUILD_ROOT%{_docdir}/%{name}
-----------------------------------------------------------

* Some more cleanup
-----------------------------------------------------------
    24  %setup -qn %{name}-%{version}
-----------------------------------------------------------
  - This can be simplified as "%setup -q" because
    the default directory of %setup is "%{name}-%{version}"

-----------------------------------------------------------
    39  cp -a ../%{name}-%{version}/* $RPM_BUILD_ROOT%{_datadir}/%{name}
-----------------------------------------------------------
  - This can be simplified as
-----------------------------------------------------------
cp -a * $RPM_BUILD_ROOT%{_datadir}/%{name}
-----------------------------------------------------------
    because at this stage the working directory is
    %{_builddir}/%{name}-%{version}

* About quickinstall.sh
  - Maybe it is good to check the id (of this script) in this script
    because at least this script needs the previledge to write to
    /usr/share/RackTables/inc/secret.php .

Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-7.src.rpm

- Simplify setup
- Step making docdir/name
- Simplify copy
- Make contrin/quickinsta.sh quit unless it's run by root

rpmlint /home/coec/rpmbuild/SRPMS/RackTables-0.17.4-7.fc11.src.rpm /home/coec/rpmbuild/RPMS/noarch/RackTables-0.17.4-7.fc11.noarch.rpm ~/rpmbuild/SPECS/RackTables.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

(In reply to comment #13)
> Spec URL: http://members.iinet.net.au/~coec/RackTables.spec
> SRPM URL: http://members.iinet.net.au/~coec/RackTables-0.17.4-7.src.rpm

$ LANG=C wget -N http://members.iinet.net.au/~coec/RackTables-0.17.4-7.src.rpm
--2009-09-14 01:12:46--  http://members.iinet.net.au/~coec/RackTables-0.17.4-7.src.rpm
Resolving members.iinet.net.au... 203.0.178.90
Connecting to members.iinet.net.au|203.0.178.90|:80... connected.
HTTP request sent, awaiting response... 401 Authorization Required
Authorization failed.

???

My sincere apologies.  This was not intentional and has been resolved.

SRPM: http://members.iinet.net.au/~coec/RackTables-0.17.4-7.fc11.src.rpm

This SRPM should address the remaining problems that you have highlighted.

Thankyou for the constructive reviews and again, my apologies.

CC

Okay.

-------------------------------------------------------
  This package (RackTables) is APPROVED by mtasaka
-------------------------------------------------------

New Package CVS Request
=======================
Package Name: RackTables
Short Description: A datacenter asset management system
Owners: coec
Branches: F-10 F-11 EL-5
InitialCC: coec

CVS done.

RackTables-0.17.4-7.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/RackTables-0.17.4-7.fc11

RackTables-0.17.4-7.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/RackTables-0.17.4-7.fc10

RackTables-0.17.4-7.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/RackTables-0.17.4-7.el5

RackTables-0.17.4-7.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update RackTables'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0473

RackTables-0.17.4-7.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update RackTables'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9705

RackTables-0.17.4-7.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update RackTables'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9797

Closing.

RackTables-0.17.4-7.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

RackTables-0.17.4-7.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

RackTables-0.17.4-7.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: RackTables
New Branches: epel7
Owners: Colin Coe

Package Change Request
======================
Package Name: RackTables
New Branches: epel7
Owners: coec

Git done (by process-git-requests).