Bug 518017

All seems ok in the spec.

Just a quick note

Froms upstream, it requires PHP 5.1.3 (which is still not available in EPEL4), so, for documentation:
BuildRequires: php-devel >= 5.1.3

A minimal %check seems usefull (even if not mandatory), for example :

%check
# simple module load test
cd %{pecl_name}-%{version}
php --no-php-ini \
    --define extension_dir=modules \
    --define extension=%{pecl_name}.so \
    --modules | grep %{pecl_name}

I will do a full review asap.

Thanks Remi,

I have updated the spec with the changes requested.

http://topdog-software.com/oss/SRPMS/fedora/php-pecl-sphinx/php-pecl-sphinx.spec
http://topdog-software.com/oss/SRPMS/fedora/php-pecl-sphinx/php-pecl-sphinx-1.0.0-2.fc11.src.rpm

REVIEW:

:) rpmlint is silent
php-pecl-sphinx.src: I: checking
php-pecl-sphinx.x86_64: I: checking
php-pecl-sphinx-debuginfo.x86_64: I: checking
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
:) package name
:) spec file name
:) package must meet the Packaging Guidelines (PHP, ...)
:) license approved (PHP)
:) license match upstream
:) no license bundled by upstream
:) specfile legible, english, UTF8
:) sources math upstream
d5bd7c00a8e036d7f82e98ebb0d9b210  sphinx-1.0.0.tgz
:) build on F-11 x86_64 against PHP 5.3.1RC1
:) build on mock (F-11 i386)
:) BR ok
:) no locale
:) no shared lib (php extension are not "real" shared lib)
:) own all directories that it creates
:) perms ok
:) %clean section
:) consistently use macros
:) contain code
:) no large doc
:) run without %doc
:) no -devel, .pc needed
:) no GUI
:) not own files or directories already owned by other packages
:) %install, with rm -rf
:) extension (un)registration ok (pecl list)
:) final Requires
/usr/bin/pecl 
libsphinxclient-0.0.1.so()(64bit)
php(api) = 20090626
php(zend-abi) = 20090626
:) final provides
php-pecl(sphinx) = 1.0.0
sphinx.so()(64bit)  
php-pecl-sphinx = 1.0.0-2.fc8
php-pecl-sphinx(x86-64) = 1.0.0-2.fc8


So : APPROVED

Thanks Remi,

New Package CVS Request
=======================
Package Name: php-pecl-sphinx
Short Description: PECL extension for Sphinx SQL full-text search engine
Owners: topdog
Branches: F-10 F-11 F-12 EL-5

CVS done.

php-pecl-sphinx-1.0.0-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/php-pecl-sphinx-1.0.0-2.fc10

php-pecl-sphinx-1.0.0-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/php-pecl-sphinx-1.0.0-2.fc11

php-pecl-sphinx-1.0.0-2.fc10 has been pushed to the Fedora 10 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pecl-sphinx'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9587

php-pecl-sphinx-1.0.0-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update php-pecl-sphinx'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9619

php-pecl-sphinx-1.0.0-2.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

php-pecl-sphinx-1.0.0-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

New Package SCM Request
=======================
Package Name: php-pecl-sphinx
Short Description: PECL extension for Sphinx SQL full-text search engine
Upstream URL: http://pecl.php.net/package/sphinx
Owners: topdog remi
Branches: epel7
InitialCC: remi

Git done (by process-git-requests).