Bug 518018
| Summary: | Review Request: zyx-liveinstaller - Install a running LiveOS rebootlessly | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Dziallas <sebastian> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jdogalt, notting, sundaram, susi.lehtola, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.1.10-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-31 23:36:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sebastian Dziallas
2009-08-18 13:52:01 UTC
Ah, got the wrong link to the source RPM. This one should be better: http://sdz.fedorapeople.org/rpmbuild/zyx-liveinstaller-0.1.10-1.fc11.src.rpm url is incorrect, should be http://filteredperception.org/smiley/projects/zyx-rli/ (In reply to comment #2) > url is incorrect, should be > http://filteredperception.org/smiley/projects/zyx-rli/ url is now correct, I fixed the website :) -dmc == Review == Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (feeaff2f9078bf86ad52a5b15cafbb528cf90e8e) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file OK Nice package, approved. Quick note: Unless you are branching this for EPEL, you don't need to define the buildroot or remove it in %install section anymore. New Package CVS Request ======================= Package Name: zyx-liveinstaller Short Description: Install a running LiveOS rebootlessly Owners: sdz Branches: F-11 CVS done @ Spot: Thanks for the review! :) @ Rahul: Won't this have rpmlint complaining on the SRPM? Yes, it it will. I have filed and got it changed from an error to just a warning and a warning is still useful since packages do get branched for EPEL but remember that our guidelines must be given higher weight than rpmlint always. zyx-liveinstaller-0.1.10-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/zyx-liveinstaller-0.1.10-2.fc11 Yup, agreed. I fixed it before building. It should be on its way on his way to Rawhide now... zyx-liveinstaller-0.1.10-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update zyx-liveinstaller'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8926 zyx-liveinstaller-0.1.10-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |