Bug 518029

Summary:	libvirt-python: virConnect class has duplicate method name!
Product:	[Community] Virtualization Tools	Reporter:	Andreas Sommer <AndiDog>
Component:	libvirt	Assignee:	Daniel Veillard <veillard>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	unspecified	CC:	berrange, crobinso, xen-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-11-13 11:21:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andreas Sommer 2009-08-18 14:28:47 UTC

Description of problem:
Look at "libvirt.py", lines 1081-1099. The method "createXML" (one for devices, one for domains) is duplicate, thus only the second one is usable. Should be renamed in some way.

Version-Release number of selected component (if applicable):
0.7.0 GIT snapshot

Comment 1 Daniel Veillard 2009-08-19 10:30:10 UTC

Right, I'm looking at it and there is some nasty things in the generator,
I will post a patch upstream shortly,

 thanks for the heads-up !

Daniel

Comment 2 Daniel Berrangé 2009-08-19 10:37:03 UTC

This is yet another occurrance of this fix we previously did

commit 61243e0f57f966d48194a4a0db50871125fe972f
Author: Daniel P. Berrange <berrange>
Date:   Wed Apr 1 10:37:57 2009 +0000

    Fix generation of networkCreateXML and storagePoolCreateXML


Same changes should work for virNetworkCreateXML too, which is what is probably causing the trouble.

Comment 3 Daniel Veillard 2009-08-19 19:21:20 UTC

Yeah, but there are other bugs in the class method name generator,
see for example in the Interface class :-)
I'm trying to clean this up a little bit to make things simpler
on the long term...

Daniel

Comment 4 Andreas Sommer 2009-09-09 10:22:33 UTC

Can you please tell me from which python-libvirt version on this bug will be corrected?

Comment 5 Daniel Berrangé 2009-11-13 11:21:28 UTC

This was fixed upstream in the previous release

commit 3f935df0af2bce49fd534f84c12e2f9931d78da8
Author: Cole Robinson <crobinso>
Date:   Wed Sep 23 12:09:09 2009 -0400

    python: Don't generate conflicting conn.createXML functions.