Bug 518083

Please refer to my comments on bug 518082 and uploade the new srpm
again.
(note that please change the release number of the spec file every time
 you modify your spec file to avoid confusion)

New package and spec file uploaded to my webserver. Please take another look.

Please refer to my comments on bug 518082 again.
Additionally:
- I see %geminstdir/test is also in this spec file, so
  adding %check section is preferable.
- Please check license (see README)

Ok. I've resolved the issues you mention. Please review one more time. 

https://wakko.is-a-geek.com/~brett/rubygem-pathname2.spec
https://wakko.is-a-geek.com/~brett/rubygem-pathname2-1.6.2-3.fc11.src.rpm

I've removed the %geminstdir/test directory for now. The tests require rubygem(test-unit), which isn't yet packaged.

(In reply to comment #4)
> I've removed the %geminstdir/test directory for now. The tests require
> rubygem(test-unit), which isn't yet packaged.  

As far as I am correct test-unit gem is needed when using ruby 1.9.x.
Now Fedora still uses ruby 1.8.x and actually test/unit.rb
exists (in ruby-libs). I guess modifying test/test_pathname.rb is
preferable to deleting this completely. Would you try this?

You're right. The test_pathname.rb only needs some minor changes to run with ruby 1.8.

Fixed that, and simplified the doc dir in the %files section.

https://wakko.is-a-geek.com/~brett/rubygem-pathname2.spec
https://wakko.is-a-geek.com/~brett/rubygem-pathname2-1.6.2-4.fc11.src.rpm

Well,

- Please fix the following rpmlint warning:
-------------------------------------------------------------
rubygem-pathname2.noarch: W: summary-ended-with-dot An alternate implementation for the Pathname library.
-------------------------------------------------------------
  Fedora suggests that Summary should not end with dot.

! Well, maybe you like to use underscore, however you can use
  hyphen in patch name (just noting).

- Source1 should be changed to Patch0 (as this is a patch)
- By the way usually applying a patch should be done at %prep
  and use %patchX macro which rpm provides.

  Current ruby packaging guideline suggests that ruby gem file
  should be installed under %buildroot at %install directly, however
  when applying a patch or executing test is needed, I usually
  suggest to once unpack gem file under %_builddir and copy the
  unpacked tree to %buildroot at %install like:
---------------------------------------------------------------
%prep
%setup -q -c -T

%{__mkdir_p} .%{gemdir}
gem install --local --install-dir=.%{gemdir} \
   --force --rdoc %{SOURCE0}

pushd .%{geminstdir}/test
%patch0 -p0
popd

%build

%install
%{__rm} -rf %{buildroot}
%{__mkdir_p} %{buildroot}%{gemdir}
%{__cp} -a .%{gemdir}/* %{buildroot}%{gemdir}/

%check
ruby -I$(pwd)%{geminstdir}/lib $(pwd)%{geminstdir}/test/test_pathname.rb

%clean
-----------------------------------------------------------------------

Fixed.  Please take another look:

https://wakko.is-a-geek.com/~brett/rubygem-pathname2.spec
https://wakko.is-a-geek.com/~brett/rubygem-pathname2-1.6.2-5.fc11.src.rpm

Well, I again forgot to point out that we now recommend to use
%global instead of %define. Please fix this when importing this
to Fedora CVS.

--------------------------------------------------------------
   This package (rubygem-pathname2) is APPROVED by mtasaka
--------------------------------------------------------------

Ok.  I'll change the %defines to %global before the first build.

New Package CVS Request
=======================
Package Name: rubygem-pathname2
Short Description: An alternate implementation for the Pathname library
Owners: wakko666
Branches: F-12
InitialCC: mtasaka

cvs done.

Closing.