Bug 518176

Summary: Build warnings about XMMS
Product: [Fedora] Fedora Reporter: Michael Schwendt <bugs.michael>
Component: xmms-crossfadeAssignee: Matthias Saou <matthias>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 11CC: matthias
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.3.14-2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-14 21:29:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michael Schwendt 2009-08-19 10:46:43 UTC
Description of problem:
http://kojipkgs.fedoraproject.org/packages/xmms-crossfade/0.3.12/5/data/logs/i686/build.log

checking for glibc threads implementation... NPTL

checking for 'is_quitting' patch in /usr/bin/xmms... not found
configure: WARNING: *** /usr/bin/xmms is not patched! ***
NOTE: For xmms-crossfade to work properly, a patch for xmms
      itself is required. Without this patch, xmms will lock up
      or segfault when exitting while a song is being played.
      This happens only with the NPTL implementation of POSIX threads.
      See patches/README for details.

checking for 'songchange' patch in /usr/bin/xmms... not found
configure: WARNING: *** /usr/bin/xmms is not patched! ***
NOTE: For xmms-crossfade to properly detect songchanges, a patch
      for xmms is available. See patches/README for details.

Comment 1 Matthias Saou 2009-09-14 20:51:07 UTC
Funny, this is actually a false positive because the configure script is doing a simple "strings" on /usr/bin/xmms, which fails to find what it's looking for because it's a symlink to /usr/libexec/xmms here.

I'll fix this in the xmms-crossfade package, but I'll also update the crossfade patch inside the main xmms package since the latest sources ship with a more recent version.

Comment 2 Matthias Saou 2009-09-14 21:29:26 UTC
It wasn't a symlink, it's a wrapper. I'm tired. I've included a somewhat ugly patch to configure* to hardcode the check on /usr/libexec/xmms since I haven't found a way to pass /usr/libexec as the first place to look for xmms.