Bug 518210

Summary:	ui instance has no attribute 'config' - self.config not initialized
Product:	[Fedora] Fedora	Reporter:	Mads Kiilerich <mads>
Component:	system-config-firewall	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	11	CC:	twoerner
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-12-13 14:25:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mads Kiilerich 2009-08-19 13:54:14 UTC

Description of problem:

after browsing through lokkit I got the following, mangled by newt tty settings:

Traceback (most recent call last):
File "/usr/bin/system-config-firewall-tui", line 41, in <module>
fw_config.ui.run()
File "/usr/share/system-config-firewall/fw_tui.py", line 863, in run
res = self.main()
File "/usr/share/system-config-firewall/fw_tui.py", line 738, in main
if self.apply() == 0:
  <T  File "/usr/share/system-config-firewall/fw_tui.py", line 625, in applyen
args = self.genArgs()
File "/usr/share/system-config-firewall/fw_tui.py", line 594, in genArgs
if self.config and self.config.services and \
  AttributeError: ui instance has no attribute 'config'


$ pylint /usr/share/system-config-firewall/fw_tui.py|grep '\<config\>'
W:197:ui.loadConfig: Attribute 'config' defined outside __init__

I assume that self.config should have been initialized to None


Version-Release number of selected component (if applicable):

system-config-firewall-tui-1.2.16-3.fc11.noarch

Comment 1 Thomas Woerner 2009-09-02 08:46:04 UTC

Fixed in git: http://git.fedorahosted.org/git/system-config-firewall.git?p=system-config-firewall.git;a=commit;h=02cd9b6e18c0d8867ff0153c27c24347ac09dcff

Will be part of next update.

Comment 2 Mads Kiilerich 2009-12-13 14:25:09 UTC

Apparently fixed in F12. Closing.