Bug 518449

Summary:	Review Request: moblin-panel-people - Moblin Panel for People
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, michel, notting
Target Milestone:	---	Flags:	michel: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-08-28 17:04:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	513452
Bug Blocks:	506446

Description Peter Robinson 2009-08-20 13:07:15 UTC

SPEC: http://pbrobinson.fedorapeople.org/moblin-panel-people.spec
SRPM: http://pbrobinson.fedorapeople.org/moblin-panel-people-0.0.1-1.fc11.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1617424

Description:
The Moblin mutter panel for managing and contacting people.

Comment 1 Michel Lind 2009-08-21 23:10:46 UTC

Everything is fine here. APPROVED.
MUST

• rpmlint: OK
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK (MD5 sum: df86408bf2291bbe01d9277217f68901)
• builds under >= 1 archs, others excluded: OK (Koji)
• build dependencies complete: OK (Koji)
• locales handled using %find_lang, no %{_datadir}/locale: OK
• own all directories: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
• package build in mock on all architectures: OK (Koji)
• package functioned as described: OK
• scriplets are sane: OK
• require package not files: OK

Comment 2 Peter Robinson 2009-08-21 23:25:42 UTC

Thanks!

New Package CVS Request
=======================
Package Name: moblin-panel-people
Short Description: Moblin Panel for People
Owners: pbrobinson
Branches: F-11
InitialCC:

Comment 3 Kevin Fenzi 2009-08-24 19:52:21 UTC

cvs done.

Comment 4 Peter Robinson 2009-08-24 22:12:36 UTC

I can't seem to check this module out. I'm getting the following errors.

$ fedora-cvs moblin-panel-people
Checking out moblin-panel-people from fedora CVS as pbrobinson:
cvs server: cannot find module `moblin-panel-people' - ignored
cvs [checkout aborted]: cannot expand modules

Comment 5 Kevin Fenzi 2009-08-26 22:33:14 UTC

oops. Try now?

Comment 6 Peter Robinson 2009-08-26 22:38:48 UTC

(In reply to comment #5)
> oops. Try now?  

Fixed. Thanks :)

Comment 7 Peter Robinson 2009-08-28 17:04:42 UTC

Imported into CVS. Has build issues at the moment as the telepathy-mission-control has broken anerley.