Bug 518486
| Summary: | Review Request: eclipse-testframework - Eclipse Test Framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, overholt |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-21 18:51:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alexander Kurtakov
2009-08-20 15:23:21 UTC
OK naming, licensing OK files OK macros OK clean, sections ? can we get a better URL ? should it depend upon eclipse >= 3.5? ? do we need to symlink to the JUnit bundles in the installation? X please version the tarball and its contents X we need an R3_5 tag passed to the fetch script. otherwise, ... OK source (md5sum doesn't match, but contents do) X rpmlint is not clean: $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/license.html eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF 0775 eclipse-testframework.noarch: W: dangling-relative-symlink /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar ../../../../../java/easymock2.jar eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: E: non-standard-dir-perm /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 0775 eclipse-testframework.noarch: W: spurious-executable-perm /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html 1 packages and 0 specfiles checked; 8 errors, 3 warnings. (In reply to comment #1) > OK naming, licensing > OK files > OK macros > OK clean, sections > ? can we get a better URL I can't find any better URL > ? should it depend upon eclipse >= 3.5? Yes, fixed. > ? do we need to symlink to the JUnit bundles in the installation? They will be resolved from the eclipse-jdt (added as requires). > X please version the tarball and its contents Done > X we need an R3_5 tag passed to the fetch script. otherwise, ... Done > OK source (md5sum doesn't match, but contents do) > > X rpmlint is not clean: > > $ rpmlint eclipse-testframework-3.5.0-1.fc11.noarch.rpm > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test.performance_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: W: spurious-executable-perm > /usr/share/doc/eclipse-testframework-3.5.0/license.html > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/META-INF > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0/META-INF > 0775 > eclipse-testframework.noarch: W: dangling-relative-symlink > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.easymock_2.4.0.v20090202-0900.jar > ../../../../../java/easymock2.jar > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/features/org.eclipse.test_3.5.0.200908201130 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test_3.2.0 > 0775 > eclipse-testframework.noarch: E: non-standard-dir-perm > /usr/share/eclipse/dropins/testframework/eclipse/plugins/org.eclipse.test.source_3.5.0.200908201130/src/org.eclipse.test_3.2.0 > 0775 > eclipse-testframework.noarch: W: spurious-executable-perm > /usr/share/doc/eclipse-testframework-3.5.0/epl-v10.html > 1 packages and 0 specfiles checked; 8 errors, 3 warnings. Done. I wasn't seeing all the errors you listed. But the only rpmlint warning i see is dangling-relative-symlink which is normal. New sources: Spec URL: http://akurtakov.fedorapeople.org/eclipse-testframework.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-testframework-3.5.0-2.fc11.src.rpm Thanks for the fixes. Approved. New Package CVS Request ======================= Package Name: eclipse-testframework Short Description: Eclipse Test Framework Owners: akurtakov overholt Branches: InitialCC: CVS Done |