Bug 518570

Summary: Unmount menuitem lingers
Product: [Fedora] Fedora Reporter: Matthias Clasen <mclasen>
Component: nautilusAssignee: Tomáš Bžatek <tbzatek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: davidz, tbzatek, tsmetana
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-24 14:52:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 473302    
Attachments:
Description Flags
nautilus-2.28.0-lacks-mount-do-not-use-activation-uri.patch none

Description Matthias Clasen 2009-08-20 23:20:26 UTC
I had an audio cd in my cd drive, then I removed it. nautilus computer window changed the icon from audio cd to cd drive as expected, but the context menu still have an unmount menuitem that complains: 

Unable to unmount Audio Disc

DBus error org.freedesktop.DBus.Error.ServiceUnknown: The name :1.86 was not provided by any .service files.

Comment 1 Matthias Clasen 2009-08-20 23:52:10 UTC
Actually, all the "Open with" menuitems for audio cds linger as well..

Comment 2 Tomáš Bžatek 2009-09-22 15:40:06 UTC
Created attachment 362113 [details]
nautilus-2.28.0-lacks-mount-do-not-use-activation-uri.patch

A simple patch, removing test for activation_uri, which sometimes cannot be determined in prior to mount (see the patch for details). This makes the Unmount menu item actually hidden after unmount. 

Attaching patch this way to have review from interested persons.

(In reply to comment #1)
> Actually, all the "Open with" menuitems for audio cds linger as well..  
Clicking the "Open with Text Editor" default action would cause automount, not showing any error. I need to test it more, we might want to disallow opening associated applications in this case.

Comment 3 Matthias Clasen 2009-09-24 14:52:56 UTC
Alex says the patch looks good, so I've pushed it upstream and in rawhide.