Bug 519118
Summary: | Review Request: nforenum - A format correcter and linter for the NFO language | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Felix Kaechele <felix> |
Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, iarnell, notting |
Target Milestone: | --- | Flags: | iarnell:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 3.4.7-0.2.r2184.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2009-09-24 05:11:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Felix Kaechele
2009-08-25 08:59:02 UTC
Two minor niggles: It doesn't look like "upx" is actually necessary for the build (only for "make release") - please remove the BuildRequires. The name of the installed binary is too generic - please rename it to "nforenum". And a very minor grammatical issue - I would also consider changing the first word of the description to "nforenum". With those tiny changes, APPROVED. + source files match upstream. diff -qr reveals no differences (svn export, checksum not suitable) + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPLv2+ + license is open source-compatible. + license text is included. + latest version is being packaged. - BuildRequires not proper. doesn't look like upx is actually necessary + compiler flags are appropriate. + %clean is present. + package builds in mock https://koji.fedoraproject.org/koji/taskinfo?taskID=1643847 + package installs properly. + rpmlint has no complaints: nforenum.src: I: checking nforenum.x86_64: I: checking nforenum-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: nforenum = 3.4.7-0.1.r2184.fc12 nforenum(x86-64) = 3.4.7-0.1.r2184.fc12 = libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.5)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. - generically named files "renum" is too generic - please rename it to "nforenum" + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Thank you very much for the review! New Package CVS Request ======================= Package Name: nforenum Short Description: A format correcter and linter for the NFO language Owners: heffer Branches: F-10 F-11 InitialCC: cvs done. nforenum-3.4.7-0.2.r2184.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/nforenum-3.4.7-0.2.r2184.fc11 nforenum-3.4.7-0.2.r2184.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nforenum'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9354 nforenum-3.4.7-0.2.r2184.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |