Bug 519221
| Summary: | Review Request: rfkill - A tool to query the state of RF kill interfaces | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John W. Linville <linville> |
| Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tomek |
| Target Milestone: | --- | Flags: | dominik:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-15 17:59:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
John W. Linville
2009-08-25 17:17:55 UTC
Packaging-wise, it looks fine, except for this: The spec file says: License: BSD However, rfkill.c has just copyright assignment, no license (=no permission to distribute) rfkill.h is GPLv2+ Additionally, the text of the license in COPYING is missing the copyright notice that must be (according to the text) retained on all copies of the software. This must be sorted out before the package can be approved. Additionally, it doesn't seem to be working out-of-the-box:
$ rfkill list
Can't open RFKILL control device: No such file or directory
strace shows:
open("/dev/rfkill", O_RDONLY) = -1 ENOENT (No such file or directory)
re: comment 2 -- your kernel doesn't have support for /dev/rfill. I assure you that it works fine here. :-) re: comment 1 -- I think rfkill.c would be fine if the COPYING file was a bit more clear. But the rfkill.h having come from the kernel throws the whole BSD license claim into doubt. :-( I'll see if I can get that sorted-out upstream... Spec URL: http://linville.fedorapeople.org/rfkill.spec SRPM URL: http://linville.fedorapeople.org/rfkill-0.3-1.fc11.src.rpm Debian ITP has IMO better description and short blurb about rfkill. It is clearer for people not familiar with "rfkill" term. #v+ Description : tool for enabling and disabling wireless devices rfkill is a simple tool for accessing the Linux rfkill device interface, which is used to enable and disable wireless networking devices, typically WLAN, Bluetooth and mobile broadband. #v- (In reply to comment #3) > re: comment 2 -- your kernel doesn't have support for /dev/rfill. I assure you > that it works fine here. :-) kernel-2.6.30.5-43.fc11.x86_64 here. Which one do I need to have /dev/rfkill? > re: comment 1 -- I think rfkill.c would be fine if the COPYING file was a bit > more clear. But the rfkill.h having come from the kernel throws the whole BSD > license claim into doubt. :-( I'll see if I can get that sorted-out > upstream... Excellent! Though I really suggest adding that BSD license to the top of rfkill.c to avoid any confusion in the future. (In reply to comment #4) > Spec URL: http://linville.fedorapeople.org/rfkill.spec > SRPM URL: http://linville.fedorapeople.org/rfkill-0.3-1.fc11.src.rpm Looks fine now, although using the improved summary and description suggested by Tomasz above will earn you extra karma. :) APPROVED. /dev/rfkill arrives in 2.6.31 kernels. I'll look at the summary and description stuff...thanks! New Package CVS Request ======================= Package Name: rfkill Short Description: A tool to query the state of RF kill interfaces Owners: linville Branches: F-11 InitialCC: linville CVS Done rfkill-0.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rfkill-0.3-2.fc11 rfkill-0.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rfkill New Branches: EL-5 Owners: linville CVS done |